Switch to soundfile for mp3 reading #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdanteleaga
force-pushed
the
sndfile
branch
6 times, most recently
from
cf48aa6
to
9b96965
Compare
|
Thanks for the changes, just a few quick comments. |
|
Did a bit more refactoring taking in some ideas from the review, let me know what you think! |
|
Thanks, I added a few more comments |
|
I think there's two more things left:
Let me know what you think |
|
I think it's fine leaving the write_mp3 public since it's extra work to extract the audio and sr from the AudioSample, if a user is doing that you'd think they would also notice the to_mp3() method available to them. I'll take care of the freezing in a PR I'm opening up in a few minutes where I'll remove the flag in the examples and display a warning if people use it. |
christhetree
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16
Might be worth it switching to wav files in the future, but this is a little bit difficult at the moment so let's do this for the competition.