Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ibis: Current Window Function Support #33

Closed
13 tasks done
dharhas opened this issue Apr 30, 2019 · 4 comments
Closed
13 tasks done

Ibis: Current Window Function Support #33

dharhas opened this issue Apr 30, 2019 · 4 comments
Assignees
@xmnlab
Labels
ibis phase 5 size: 25 sow
Milestone
Phase 5

Comments

@dharhas
Copy link
Member

dharhas commented Apr 30, 2019 •
edited by xmnlab
Loading

Land initial support for current window function impl in omnisci.

  • rank (~2h)
  • dense_rank (~2h)
  • row_number (~2h)
  • cume_dist (~2h)
  • lag (~2h)
  • first_value (~2h)
  • lead (~2h)
  • last_value (~2h)
  • avg (~2h)
  • min (~2h)
  • max (~2h)
  • count (~2h)
  • sum (~2h)

total: ~30h

ref: https://github.com/omnisci/mapd-core/blob/master/Tests/ExecuteTest.cpp#L14107
@xmnlab xmnlab self-assigned this Apr 30, 2019
@xmnlab xmnlab transferred this issue from another repository Apr 30, 2019
@xmnlab xmnlab added this to the Phase 5 milestone May 1, 2019
@xmnlab
Copy link
Contributor

xmnlab commented May 10, 2019 •
edited
Loading

First round of operations merged! ibis-project/ibis#1771

@dharhas dharhas added the blocked label Aug 6, 2019
@xmnlab xmnlab added the size: 15 label Aug 8, 2019
@xmnlab
Copy link
Contributor

xmnlab commented Aug 8, 2019

Added size: 15 for the missing operations.

@xmnlab
Copy link
Contributor

xmnlab commented Sep 22, 2019 •
edited
Loading

WIP PR: ibis-project/ibis#1976

Currently there is an issue related to percent_rank and cume_dist operations: ibis-project/ibis#1975

Currently, OmniSciDB stable version does support - 1 for window operations. This PR uses a development version of OmniSciDB (omnisci/core-os-cpu-dev:873026091ff8a12535b50ce27e08e2c95c5c01fe).

- 1 support for window operations should land on OmniSciDB on v5.0, planned for early November.

@Abaal Abaal added size: 25 and removed size: 15 labels Oct 1, 2019
@xmnlab
Copy link
Contributor

xmnlab commented Jan 29, 2020

PS: I am moving percent_rank and ntile to new issues

@xmnlab xmnlab closed this as completed Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xmnlab xmnlab

Labels
ibis phase 5 size: 25 sow
Projects
None yet
Milestone
Phase 5
Development

No branches or pull requests
3 participants
@dharhas @Abaal @xmnlab