First version of omnisci window op

[xmnlab]

This PR adds window operations for OmniSci/MapD backend:

• lag
• firstvalue
• lead
• lastvalue
• mean
• min
• max
• sum

[cpcloud]

@xmnlab Can you split this into 2 PRs? One with all the build/data loading related changes and one with the window changes?

[cpcloud]

@xmnlab Can you rebase here? Sorry for the merge conflicts, let me know if you'd like me to help resolve them.

[xmnlab]

@cpcloud ! sounds pretty good .. I will open a new PR with the changes related to new omnisci database docker. and after that I will move this PR forward :)

[xmnlab]

the PR for the omnisci ci: updating #1781

[codecov]

Codecov Report

Merging #1771 into master will decrease coverage by 2.01%.
The diff coverage is 51.11%.

@@            Coverage Diff             @@
##           master    #1771      +/-   ##
==========================================
- Coverage   87.57%   85.56%   -2.02%     
==========================================
  Files          80       80              
  Lines       15145    15190      +45     
  Branches     1958     1969      +11     
==========================================
- Hits        13263    12997     -266     
- Misses       1529     1834     +305     
- Partials      353      359       +6

Impacted Files	Coverage Δ
ibis/mapd/operations.py	71.32% <51.11%> (-2.51%)	⬇️
ibis/bigquery/client.py	41.1% <0%> (-53.39%)	⬇️
ibis/bigquery/compiler.py	59.92% <0%> (-37.5%)	⬇️
ibis/bigquery/udf/api.py	80.48% <0%> (-14.64%)	⬇️
ibis/bigquery/api.py	63.33% <0%> (-10.01%)	⬇️
ibis/impala/compiler.py	91.28% <0%> (-5.6%)	⬇️
ibis/pandas/client.py	85.63% <0%> (-3.45%)	⬇️
ibis/expr/schema.py	89.77% <0%> (-1.14%)	⬇️
ibis/expr/window.py	86.46% <0%> (-0.76%)	⬇️
ibis/expr/api.py	93.53% <0%> (-0.4%)	⬇️
... and 3 more

[xmnlab]

@cpcloud it seems it is done for a review :)

[cpcloud]

Merging on green.

[xmnlab]

thanks @cpcloud !

[cpcloud]

Just fixed up the merge conflict in the github UI, will wait for at least one the py36/py37 builds to turn green then will merge. Thanks @xmnlab!

[cpcloud]

@xmnlab Can you disable the any and all tests for mapd for now? I changed them to enable testing without calling into the cumulative operations interface to be more consistent with the rest of the test cases in that file.

Sorry for the churn!

[xmnlab]

@cpcloud sure .. I will do it now. thanks!

[xmnlab]

not sure why it broke just for py35 with this error:

INTERNALERROR> AssertionError: ('ibis/tests/all/test_window.py::test_window[MapD-cumany]', <WorkerController gw1>)
INTERNALERROR> assert not 'ibis/tests/all/test_window.py::test_window[MapD-cumany]'

maybe I should just add these ops as unsupported for window operations

[xmnlab]

@cpcloud it is done :)

[cpcloud]

Thanks, I will merge when I get to the office around 10a Eastern!

[xmnlab]

Thanks @cpcloud! El jue., 16 de mayo de 2019 06:58, Phillip Cloud <notifications@github.com> escribió:

…

Thanks, I will merge when I get to the office around 10a Eastern! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1771?email_source=notifications&email_token=ABHX5HINVUGB4M6A33KAAYDPVU45ZA5CNFSM4HL64TN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVRONHA#issuecomment-493020828>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABHX5HLOKUGAOBLUVTVINZTPVU45ZANCNFSM4HL64TNQ> .