Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrates Hadolint for Dockerfile linting #917

Merged
merged 7 commits into from
Nov 16, 2021
Merged

Integrates Hadolint for Dockerfile linting #917

merged 7 commits into from
Nov 16, 2021

Conversation

HarshCasper
Copy link
Contributor

@HarshCasper HarshCasper commented Nov 11, 2021

Changes:

  • Adds a .hadolint.yml for linting Dockerfiles using Hadolint
  • Adds relevant docs to run Hadolint locally
  • Integrates the CI with Hadolint to look for errors on every commit
  • Adds hadolint pre-commit hook

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

@iameskild
Copy link
Member

@HarshCasper thanks for working on this! Now that Amit has cleaned up CI, we should aim to get all green checks before merging. I would suggesting:

  • merging main into this branch
  • fixing the vale related errors by by having vale ignore instances of Hadoling and Dockerfile

Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HarshCasper! LGTM

@iameskild iameskild merged commit 07bba79 into main Nov 16, 2021
@HarshCasper HarshCasper deleted the hadolint branch November 17, 2021 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants