-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instructions to install from conda-forge. #396
Conversation
Hi @pmeier ! I attended your workshop at PyData Berlin last week - thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah nice, thanks Kevin! We had a try earlier at this (conda-forge/staged-recipes#24706), but hit some blockers.
One thing that I'm wondering though: our recommendation is to pip install ragna[all]
and only go for pip install ragna
if one wants fine grained control. For conda this is "flipped" given that there are no optional dependencies. Meaning, users will always install the minimal version and have no way to automatically install the one with batteries included.
That sucks from a UX perspective. Let me ask around if there is a good solution to the problem. I'm sure we are not the first ones to hit this.
@pmeier thanks for your response!
I understand. Iirc the way this is usually done is to have two outputs in the conda recipe. For instance, the matplotlib recipe has one output called Should I look into setting this up, tag you in the feedstock PR, and create a follow-up ragna PR once this is settled? |
That is what I got from my sources as well.
Yes, that would be awesome. TBH, we should probably have a discussion about the same for our PyPI releases. Not only will it be awkward if conda and pip installs diverge, but also |
Maybe hold off on this one. I'll start an issue soon on how we want to do this. I got some conflicting opinions from people that know conda / conda-forge a lot better than me. |
commit 04168ab Author: Arjun Verma <arjunverma.oc@gmail.com> Date: Wed May 1 12:35:41 2024 +0530 #373 Include documentation_helpers in module (#395) Co-authored-by: Philip Meier <github.pmeier@posteo.de> commit f947f2d Author: Philip Meier <github.pmeier@posteo.de> Date: Mon Apr 29 17:08:40 2024 +0200 bump mypy to 1.10 (#398) commit e0fe014 Author: Kevin Klein <7267523+kklein@users.noreply.github.com> Date: Mon Apr 29 12:52:49 2024 +0200 Add instructions to install from conda-forge. (#396) Co-authored-by: Philip Meier <github.pmeier@posteo.de> commit 7963453 Author: Philip Meier <github.pmeier@posteo.de> Date: Thu Apr 25 20:38:50 2024 +0200 use custom JSON type for database for more generic support (#389) commit 3a5b82d Author: William Black <125844868+smokestacklightnin@users.noreply.github.com> Date: Wed Apr 24 01:37:48 2024 -0700 Remove Mosaic Assistant (#387)
Co-authored-by: Philip Meier <github.pmeier@posteo.de>
ragna has recently been brought to conda-forge; see this feestock and the package information.
This PR