Sentiment analysis #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 20 commits
November 6, 2017 13:32
complexity builtins
in setup.py
nltk fixes
nltk troubles
added 2 commits
November 17, 2017 11:33
Closed
OliverSherouse
requested changes
Nov 27, 2017
quantgov/corpora/utils.py
Outdated
|
|
||
| @decorator | ||
| def check_nltk(func, *args, **kwargs): | ||
| if args[-1] is None: |
There was a problem hiding this comment.
Why are we passing this as an argument? It's available module wide. Just do if NLTK
quantgov/corpora/utils.py
Outdated
|
|
||
| @decorator | ||
| def check_textblob(func, *args, **kwargs): | ||
| if args[-2] is None: |
There was a problem hiding this comment.
Same thing here. if textblob is None
setup.cfg
Outdated
| @@ -3,7 +3,7 @@ universal = 1 | |||
| [tool:pytest] | |||
| addopts = --flake8 | |||
| flake8-ignore = | |||
| *.py W391 W503 | |||
| *.py W391 W503 F821 | |||
There was a problem hiding this comment.
We can't ignore this; it's an important error. Where are you getting it?
setup.py
Outdated
| 'textblob', | ||
| 'nltk', | ||
| 'decorator' | ||
| ] |
There was a problem hiding this comment.
Decorator needs to be in the main requires, since it's used regardless. I don't like the name builtins; maybe nlp?
quantgov/corpora/builtins.py
Outdated
| help='Performs sentiment analysis on the text', | ||
| arguments=[ | ||
| quantgov.utils.CLIArg( | ||
| flags=('--analyzer'), |
There was a problem hiding this comment.
Did I tell you to do this? If not, it's good forward thinking! But a bad variable name. Maybe "backend"?
quantgov/corpora/builtins.py
Outdated
| sentences = textblob.TextBlob(doc.text).sentences | ||
| return doc.index + (round(sum(len( | ||
| sentence.words) for sentence in sentences) / | ||
| len(sentences), int(precision)),) |
There was a problem hiding this comment.
What if the user wants unrounded output? Maybe if precision = None return unrounded, otherwise the rounded version.
quantgov/corpora/builtins.py
Outdated
|
|
||
| import quantgov | ||
|
|
||
| try: | ||
| import nltk.corpus |
There was a problem hiding this comment.
Not to make this more complicated than it already is, but we need specific NLTK corpora, right? We should check for those and either download them automatically or (probably better) tell the user how to do so.
|
@OliverSherouse ready for another look |
OliverSherouse
approved these changes
Nov 28, 2017
OliverSherouse
added a commit
that referenced
this pull request
Apr 17, 2018
* Inaugurated 0.4.0 dev series * Sentiment analysis (#33) Closes #11 #12 #13 and adds Sentiment analysis! * complexity * complexity builtins * complexity builtins with tests * code review updates * option tests * added nltk requirement in setup.py * add pip install to .travis.yml * nltk fixes * another nltk fix * last nltk fix? * you know the drill * Update .travis.yml * nltk troubles * some final cleanup * if it aint broke... * textblob sentiment * tests and error raising * fixed install req * pep8 fixes * code review updates * fix travis file * import fixes * small fix * Test corpora (#35) * complexity * complexity builtins * complexity builtins with tests * code review updates * option tests * added nltk requirement in setup.py * add pip install to .travis.yml * nltk fixes * another nltk fix * last nltk fix? * you know the drill * Update .travis.yml * nltk troubles * some final cleanup * new corpora in English!! * hotfix to add timestamp as corpus identifier * Skl compatibility (#41) * Add sklearn 0.17 compatibility Paper over library reorganization. * renamed corpora to corpus, added deprecation warning (#42) * renamed corpora to corpus, added deprecation warning * moved load_driver and set up for future forcing of full imports of submodules Closes #31 * S3 drivers (#44) * initial working commit for s3 driver and database driver * removing 3.6 formatting * adding extra requirements list * adding basic s3 driver test * Removing unnecessary function * This ain't 2007 * test updates * adding s3driver to new corpus structure * Rounding (#45) * bumped version
OliverSherouse
added a commit
that referenced
this pull request
Apr 17, 2018
* Inaugurated 0.4.0 dev series * Sentiment analysis (#33) Closes #11 #12 #13 and adds Sentiment analysis! * complexity * complexity builtins * complexity builtins with tests * code review updates * option tests * added nltk requirement in setup.py * add pip install to .travis.yml * nltk fixes * another nltk fix * last nltk fix? * you know the drill * Update .travis.yml * nltk troubles * some final cleanup * if it aint broke... * textblob sentiment * tests and error raising * fixed install req * pep8 fixes * code review updates * fix travis file * import fixes * small fix * Test corpora (#35) * complexity * complexity builtins * complexity builtins with tests * code review updates * option tests * added nltk requirement in setup.py * add pip install to .travis.yml * nltk fixes * another nltk fix * last nltk fix? * you know the drill * Update .travis.yml * nltk troubles * some final cleanup * if it aint broke... * new corpora in English!! * hotfix to add timestamp as corpus identifier * Skl compatibility (#41) * Add sklearn 0.17 compatibility Paper over library reorganization. * renamed corpora to corpus, added deprecation warning (#42) * renamed corpora to corpus, added deprecation warning * moved load_driver and set up for future forcing of full imports of submodules Closes #31 * S3 drivers (#44) * initial working commit for s3 driver and database driver * removing 3.6 formatting * adding extra requirements list * adding basic s3 driver test * Removing unnecessary function * This ain't 2007 * test updates * adding s3driver to new corpus structure * Rounding (#45) * bumped version * Fix NLTK loading bug Fix evaluation order when NLTK is not present
OliverSherouse
added a commit
that referenced
this pull request
May 21, 2018
* hotfix to add timestamp as corpus identifier (#39) * bumped version * Release 0.4 (#47) * Inaugurated 0.4.0 dev series * Sentiment analysis (#33) Closes #11 #12 #13 and adds Sentiment analysis! * complexity * complexity builtins * complexity builtins with tests * code review updates * option tests * added nltk requirement in setup.py * add pip install to .travis.yml * nltk fixes * another nltk fix * last nltk fix? * you know the drill * Update .travis.yml * nltk troubles * some final cleanup * if it aint broke... * textblob sentiment * tests and error raising * fixed install req * pep8 fixes * code review updates * fix travis file * import fixes * small fix * Test corpora (#35) * complexity * complexity builtins * complexity builtins with tests * code review updates * option tests * added nltk requirement in setup.py * add pip install to .travis.yml * nltk fixes * another nltk fix * last nltk fix? * you know the drill * Update .travis.yml * nltk troubles * some final cleanup * new corpora in English!! * hotfix to add timestamp as corpus identifier * Skl compatibility (#41) * Add sklearn 0.17 compatibility Paper over library reorganization. * renamed corpora to corpus, added deprecation warning (#42) * renamed corpora to corpus, added deprecation warning * moved load_driver and set up for future forcing of full imports of submodules Closes #31 * S3 drivers (#44) * initial working commit for s3 driver and database driver * removing 3.6 formatting * adding extra requirements list * adding basic s3 driver test * Removing unnecessary function * This ain't 2007 * test updates * adding s3driver to new corpus structure * Rounding (#45) * bumped version * Fix NLTK loading bug Fix evaluation order when NLTK is not present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also raises errors if certain modules are not installed