Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skl compatibility #41

Merged
merged 4 commits into from
Mar 23, 2018
Merged

Skl compatibility #41

merged 4 commits into from
Mar 23, 2018

Conversation

OliverSherouse
Copy link
Member

Adds compatibility for scikit-learn 0.17, which is needed to use the old RegData 2.2 estimators in the new framework

Paper over library reorganization.
this is why we don't edit files on the web.
Copy link
Member

@jnelson16 jnelson16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@OliverSherouse OliverSherouse merged commit 4858bbe into dev Mar 23, 2018
@OliverSherouse OliverSherouse deleted the skl_compatibility branch March 23, 2018 18:26
OliverSherouse added a commit that referenced this pull request Apr 17, 2018
* Inaugurated 0.4.0 dev series

* Sentiment analysis (#33)

Closes #11 #12  #13 and adds Sentiment analysis!

* complexity

* complexity builtins

* complexity builtins with tests

* code review updates

* option tests

* added nltk requirement

in setup.py

* add pip install to .travis.yml

* nltk fixes

* another nltk fix

* last nltk fix?

* you know the drill

* Update .travis.yml

* nltk troubles

* some final cleanup

* if it aint broke...

* textblob sentiment

* tests and error raising

* fixed install req

* pep8 fixes

* code review updates

* fix travis file

* import fixes

* small fix

* Test corpora (#35)

* complexity

* complexity builtins

* complexity builtins with tests

* code review updates

* option tests

* added nltk requirement

in setup.py

* add pip install to .travis.yml

* nltk fixes

* another nltk fix

* last nltk fix?

* you know the drill

* Update .travis.yml

* nltk troubles

* some final cleanup

* new corpora

in English!!

* hotfix to add timestamp as corpus identifier

* Skl compatibility (#41)

* Add sklearn 0.17 compatibility

Paper over library reorganization.

* renamed corpora to corpus, added deprecation warning (#42)

* renamed corpora to corpus, added deprecation warning
* moved load_driver and set up for future forcing of full imports of submodules

Closes #31

* S3 drivers (#44)

* initial working commit for s3 driver and database driver

* removing 3.6 formatting

* adding extra requirements list

* adding basic s3 driver test

* Removing unnecessary function

* This ain't 2007

* test updates

* adding s3driver to new corpus structure

* Rounding (#45)

* bumped version
OliverSherouse added a commit that referenced this pull request Apr 17, 2018
* Inaugurated 0.4.0 dev series

* Sentiment analysis (#33)

Closes #11 #12  #13 and adds Sentiment analysis!

* complexity

* complexity builtins

* complexity builtins with tests

* code review updates

* option tests

* added nltk requirement

in setup.py

* add pip install to .travis.yml

* nltk fixes

* another nltk fix

* last nltk fix?

* you know the drill

* Update .travis.yml

* nltk troubles

* some final cleanup

* if it aint broke...

* textblob sentiment

* tests and error raising

* fixed install req

* pep8 fixes

* code review updates

* fix travis file

* import fixes

* small fix

* Test corpora (#35)

* complexity

* complexity builtins

* complexity builtins with tests

* code review updates

* option tests

* added nltk requirement

in setup.py

* add pip install to .travis.yml

* nltk fixes

* another nltk fix

* last nltk fix?

* you know the drill

* Update .travis.yml

* nltk troubles

* some final cleanup

* if it aint broke...

* new corpora

in English!!

* hotfix to add timestamp as corpus identifier

* Skl compatibility (#41)

* Add sklearn 0.17 compatibility

Paper over library reorganization.

* renamed corpora to corpus, added deprecation warning (#42)

* renamed corpora to corpus, added deprecation warning
* moved load_driver and set up for future forcing of full imports of submodules

Closes #31

* S3 drivers (#44)

* initial working commit for s3 driver and database driver

* removing 3.6 formatting

* adding extra requirements list

* adding basic s3 driver test

* Removing unnecessary function

* This ain't 2007

* test updates

* adding s3driver to new corpus structure

* Rounding (#45)

* bumped version

* Fix NLTK loading bug

Fix evaluation order when NLTK is not present
OliverSherouse added a commit that referenced this pull request May 21, 2018
* hotfix to add timestamp as corpus identifier (#39)

* bumped version

* Release 0.4 (#47)

* Inaugurated 0.4.0 dev series

* Sentiment analysis (#33)

Closes #11 #12  #13 and adds Sentiment analysis!

* complexity

* complexity builtins

* complexity builtins with tests

* code review updates

* option tests

* added nltk requirement

in setup.py

* add pip install to .travis.yml

* nltk fixes

* another nltk fix

* last nltk fix?

* you know the drill

* Update .travis.yml

* nltk troubles

* some final cleanup

* if it aint broke...

* textblob sentiment

* tests and error raising

* fixed install req

* pep8 fixes

* code review updates

* fix travis file

* import fixes

* small fix

* Test corpora (#35)

* complexity

* complexity builtins

* complexity builtins with tests

* code review updates

* option tests

* added nltk requirement

in setup.py

* add pip install to .travis.yml

* nltk fixes

* another nltk fix

* last nltk fix?

* you know the drill

* Update .travis.yml

* nltk troubles

* some final cleanup

* new corpora

in English!!

* hotfix to add timestamp as corpus identifier

* Skl compatibility (#41)

* Add sklearn 0.17 compatibility

Paper over library reorganization.

* renamed corpora to corpus, added deprecation warning (#42)

* renamed corpora to corpus, added deprecation warning
* moved load_driver and set up for future forcing of full imports of submodules

Closes #31

* S3 drivers (#44)

* initial working commit for s3 driver and database driver

* removing 3.6 formatting

* adding extra requirements list

* adding basic s3 driver test

* Removing unnecessary function

* This ain't 2007

* test updates

* adding s3driver to new corpus structure

* Rounding (#45)

* bumped version

* Fix NLTK loading bug

Fix evaluation order when NLTK is not present
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants