Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: add option to choose date and calendar format #45

Open
nach0 opened this issue Feb 18, 2024 · 2 comments
Open

Request: add option to choose date and calendar format #45

nach0 opened this issue Feb 18, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@nach0
Copy link

nach0 commented Feb 18, 2024

Currently when selecting English as app language, the date format is automatically set to MM/DD/YYYY, and in the calendar view Sunday is the first day of the week.

Many people choose English as interface language but don't live in the US nor use the US date format. It would be nice to give the users the option to choose the date format and the first day of the week in the calendar view.

@braniii braniii added the enhancement New feature or request label Mar 8, 2024
@olker159
Copy link

olker159 commented Oct 7, 2024

Hi, I would like to contribute to this project by trying to solve this issue. Is this issue still relevant?

@braniii
Copy link
Contributor

braniii commented Oct 8, 2024

Hi @olker159 this issue is still open. And I would be very happy to assist you with this task :) Right now there is a major rewrite to include some more statistics to keep the user motivated, see #31. There we change the measurement list, so changing it as well will cause merge conflicts. We (or better @gwosd ) will try to finish it the next days.

Because the source code is a mess, here is brief list of steps on how I would tackle it.

  • add two Enums which stands for the firstDay of the week and different date printing formats. Both time including the system default as one option. You can check, e.g. the units class in lib/core/units.dart. using extensions to allow a nice parsing makes the next steps much easier.
  • include both of them into the preferences and traleNotifier.
  • add two drop down ListTile in the setting pages, similar to the language selection
  • to allow changing the first day of the week in the calendar view, we should switch to calendar_date_picker2 in both dialogs.
  • and to change the displayed weight, one need to add a new printing function. But this will cause merging issue, due to the open PR Overall UI improvement #31.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants