Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make events look like events #43

Closed
KidkArolis opened this issue Aug 30, 2014 · 1 comment
Closed

Make events look like events #43

KidkArolis opened this issue Aug 30, 2014 · 1 comment
Milestone

Comments

@KidkArolis
Copy link
Contributor

There are a couple of events in the routes: willTransition, error and queryParamsDidChange - consider making it explicit that they're events by putting them into route.events.willTransition or so like the original router.js does it.

Events are special in that they're called from the right most route to the top, and the propagation of them can be stopped so it's worth making them look different from the rest of the hooks.

@KidkArolis
Copy link
Contributor Author

Not relevant in 2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant