-
-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Swift 2.2 #243
[WIP] Swift 2.2 #243
Conversation
Originally brought up in Quick#242, `XCTest` methods now take `StaticString` (see swiftlang/swift#888 for details). Unfortunately this won't compile now because `StaticString` is not available in Objective-C!
Hey @NachoSoto, thanks for taking a stab at this. I'm disappointed that nobody (including myself!) realized the ObjC bridging implications while discussing the Assuming that the change doesn't get reverted, though, does anybody have thoughts on how to work around this change? The only thing I've got so far would be to switch to bypass the Swift overlay and use the Objective-C |
I feel this would've taken a great deal of foresight, from someone with a ton of context on |
Hah, disappointment was probably too strong a word. Let's rather call it mild annoyance at being caught off guard by the ramifications of a change that I was involved in 😂 Anyway, @NachoSoto and (@ratkins), I'm curious to hear how urgent you feel it is for us to try to get support for Xcode 7.3 beta 2? Even if swiftlang/swift#888 ends up getting reverted (I'm not holding my breath! And I'm not even fully convinced that it should be, at this point), it will be a few weeks until the next beta rolls around. |
Thanks guys! There's definitely no rush for this beta. I just usually like to get a head start to find things like this (or like many other bad things I've found over the years 😅). I think we should consider this important, otherwise I can already see a 7.3 GM with this bug that would mean Nimble can't support Objective-C anymore, or that compromises have to be made :P |
My situation is, I want to try running our suite under 7.3b2 so I can tell if it fixes other (Xcode) bugs that are causing our CI to fail—so I can feed that back in to the 7.3 beta. But at the same time I need to keep our master branch 7.2 compatible so we can release through TestFlight. I'm not sure what the best approach to this would be for us (with the added constraint that I'm only going to be on the project for another week, before sending the client home with whatever path forward I can come up with.) |
I'm traveling right now and don't have connectivity for my laptop, but I've put s branch together with one approach to resolving this which I hope to push for review tomorrow. (Just a heads up in case anyone was was considering taking a stab at it!) |
Continued in #244. |
I've changed all types for
__FILE__
toFileString
, and it made that alwaysStaticString
to matchXCTest
.This was originally brought up in #242:
XCTest
methods now takeStaticString
(see swiftlang/swift#888 for details). Unfortunately this won't compile now becauseStaticString
is not available in Objective-C!