Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot convert value of type 'String' to expected argument type 'StaticString' under Xcode 7.3b2/Swift 2.2 #242

Closed
ratkins opened this issue Jan 26, 2016 · 15 comments

Comments

@ratkins
Copy link

ratkins commented Jan 26, 2016

Compiling under Xcode 7.3 beta 2 I get:

Bot Issue for My Bot (error in NimbleXCTestHandler.swift:25)
Assertion: Cannot convert value of type 'String' to expected argument type 'StaticString'
File: [...]/Carthage/Checkouts/nimble/Nimble/Adapters/NimbleXCTestHandler.swift:25

(also NimbleXCTestHandler.swift:9)

@briancroom
Copy link
Member

Thanks for the report @ratkins. To verify, you are actually using Xcode 7.3 beta 2, correct?

This is because Xcode is now shipping with betas of Swift 2.2, which includes swiftlang/swift#888

@jeffh it may be necessary to introduce a Swift 2.2 branch to accommodate this breaking change.

@ratkins
Copy link
Author

ratkins commented Jan 26, 2016

(ja, sorry—7.3)

@modocache
Copy link
Member

Ah, life on the bleeding edge! I'm thankful we now get to see these changes propagate in apple/swift and apple/swift-corelibs-xctest before users encounter them on the latest Xcode beta. 😇

NachoSoto added a commit to NachoSoto/Nimble that referenced this issue Jan 27, 2016
Originally brought up in Quick#242, `XCTest` methods now take `StaticString` (see swiftlang/swift#888 for details), so this won't compile just yet.
NachoSoto added a commit to NachoSoto/Nimble that referenced this issue Jan 27, 2016
Originally brought up in Quick#242, `XCTest` methods now take `StaticString` (see swiftlang/swift#888 for details). Unfortunately this won't compile now because `StaticString` is not available in Objective-C!
@paulz
Copy link

paulz commented Jan 29, 2016

Just got this error today on Xcode 7.3 beta, here is the complete list of errors and warnings:

Nimble/Adapters/NimbleXCTestHandler.swift:9:64: error: cannot convert value of type 'String' to expected argument type 'StaticString'
Nimble/Adapters/NimbleXCTestHandler.swift:25:48: error: cannot convert value of type 'String' to expected argument type 'StaticString'
Nimble/Matchers/Contain.swift:30:33: warning: 'init(start:end:)' is deprecated: it will be removed in Swift 3.  Use the '..<' operator.
Nimble/Matchers/Contain.swift:30:33: warning: 'init(start:end:)' is deprecated: it will be removed in Swift 3.  Use the '..<' operator.
Nimble/Matchers/Contain.swift:30:33: warning: 'init(start:end:)' is deprecated: it will be removed in Swift 3.  Use the '..<' operator.
Nimble/Matchers/SatisfyAnyOf.swift:13:56: warning: '++' is deprecated: it will be removed in Swift 3
Nimble/Matchers/SatisfyAnyOf.swift:13:9: warning: C-style for statement is deprecated and will be removed in a future version of Swift
Nimble/Matchers/SatisfyAnyOf.swift:13:56: warning: '++' is deprecated: it will be removed in Swift 3
xcodebuild -version
Xcode 7.3
Build version 7D129n

@jeffh
Copy link
Member

jeffh commented Feb 3, 2016

I've merged this on to master. I'll cut a release soon.

@jeffh
Copy link
Member

jeffh commented Feb 3, 2016

Also, @briancroom. The changes looked compatible enough to just bump the major version and not have to warrant cutting a separate branch. That sounds ok?

@briancroom
Copy link
Member

@jeffh yes, I do believe that I managed to achieve compatibility with those changes 👍

mokagio added a commit to mokagio/KeyboardAnimationSubscriber that referenced this issue Feb 19, 2016
@Hout
Copy link

Hout commented Feb 22, 2016

beta 3 has the same issue

@JanC
Copy link

JanC commented Mar 13, 2016

Hi

I've merged this on to master. I'll cut a release soon.

any update on this? It would be nice to have a release or beta with Siwft 2.2 in CocoaPods

@briancroom
Copy link
Member

@jeffh were there any outstanding items you were hoping to get in before a release? If it's just a time issue, I'd be more than happy to give it a go myself.

I had initially been thinking it would make sense to wait until #261 could be merged, but now it looks like the next snapshot is going to include breaking changes related to Swift 3, so I'd say let's go for it!

@jeffh
Copy link
Member

jeffh commented Mar 14, 2016

Go for it! I usually just do some manual verification before cutting a
release. If you have some missing permission, let me know.

On Sun, Mar 13, 2016 at 10:23 PM Brian Croom notifications@github.com
wrote:

@jeffh https://github.com/jeffh were there any outstanding items you
were hoping to get in before a release? If it's just a time issue, I'd be
more than happy to give it a go myself.

I had initially been thinking it would make sense to wait until #261
#261 could be merged, but now it
looks like the next snapshot is going to include breaking changes related
to Swift 3, so I'd say let's go for it!


Reply to this email directly or view it on GitHub
#242 (comment).

@briancroom
Copy link
Member

Hey @jeffh I got started writing up release notes but realized I don't have pod trunk access to Quick or Nimble. Could you add me as a maintainer there? Thanks!

@modocache
Copy link
Member

@briancroom Done! I added you to Quick and Nimble.

@briancroom
Copy link
Member

Sorry for the delay, but the release has been made now! Let me know if you have any issues: https://github.com/Quick/Nimble/releases/tag/v3.2.0

@briancroom
Copy link
Member

I'm going to go ahead and close this now that the release is out. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants