Implement the async variant of toEventually using structured concurrency #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... mostly. This replaces the Dispatch-based version of async toEventually with one that uses native Swift Concurrency components This was done to eliminate the chance that the matcher could be polled more than one at a time, and to also make way for future Sendable requirements.
younata
commented
Sep 11, 2023
…protocol This allows us to longer have to verify time intervals in test, removing a source of test flakiness
cgrindel-self-hosted-renovate bot
added a commit
to cgrindel/rules_swift_package_manager
that referenced
this pull request
Sep 18, 2023
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [Quick/Nimble](https://togithub.com/Quick/Nimble) | minor | `from: "12.2.0"` -> `from: "12.3.0"` | --- ### Release Notes <details> <summary>Quick/Nimble (Quick/Nimble)</summary> ### [`v12.3.0`](https://togithub.com/Quick/Nimble/releases/tag/v12.3.0) [Compare Source](https://togithub.com/Quick/Nimble/compare/v12.2.0...v12.3.0) #### Highlights - the async variant of `toEventually` no longer kicks off unstructured background tasks to check that the matcher matches. This means that there will no longer be the possibility that the same value will be being checked by multiples of the same matcher. #### What's Changed - Bump activesupport from 7.0.4.3 to 7.0.7.2 by [@​dependabot](https://togithub.com/dependabot) in [Quick/Nimble#1080 - Bump actions/checkout from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [Quick/Nimble#1081 - Implement the async variant of toEventually using structured concurrency by [@​younata](https://togithub.com/younata) in [Quick/Nimble#1079 - Fix all swiftlint warnings by [@​younata](https://togithub.com/younata) in [Quick/Nimble#1085 **Full Changelog**: Quick/Nimble@v12.2.0...v12.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi45Ni4wIiwidXBkYXRlZEluVmVyIjoiMzYuOTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the Dispatch-based version of async toEventually with one that uses native Swift Concurrency components This was done to eliminate the chance that the matcher could be polled more than one at a time, and to also make way for future Sendable requirements.
This is a drop-in replacement for the Dispatch-Based approach to the async variant.
The PR should summarize what was changed and why. Here are some questions to
help you if you're not sure:
Checklist - While not every PR needs it, new features should consider this list: