Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all swiftlint warnings #1085

Merged
merged 2 commits into from Sep 14, 2023
Merged

Fix all swiftlint warnings #1085

merged 2 commits into from Sep 14, 2023

Conversation

younata
Copy link
Member

@younata younata commented Sep 13, 2023

Noticed we're having quite a large amount of SwiftLint errors. This addresses all of them.

Checklist - While not every PR needs it, new features should consider this list:

  • Does this have tests?
  • Does this have documentation?
  • Does this break the public API (Requires major version bump)?
  • Is this a new feature (Requires minor version bump)?

@younata younata merged commit 9f3afda into main Sep 14, 2023
13 checks passed
@younata younata deleted the fix_swiftlint_again branch September 14, 2023 18:31
cgrindel-self-hosted-renovate bot added a commit to cgrindel/rules_swift_package_manager that referenced this pull request Sep 18, 2023
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [Quick/Nimble](https://togithub.com/Quick/Nimble) | minor | `from:
"12.2.0"` -> `from: "12.3.0"` |

---

### Release Notes

<details>
<summary>Quick/Nimble (Quick/Nimble)</summary>

### [`v12.3.0`](https://togithub.com/Quick/Nimble/releases/tag/v12.3.0)

[Compare
Source](https://togithub.com/Quick/Nimble/compare/v12.2.0...v12.3.0)

#### Highlights

- the async variant of `toEventually` no longer kicks off unstructured
background tasks to check that the matcher matches. This means that
there will no longer be the possibility that the same value will be
being checked by multiples of the same matcher.

#### What's Changed

- Bump activesupport from 7.0.4.3 to 7.0.7.2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[Quick/Nimble#1080
- Bump actions/checkout from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[Quick/Nimble#1081
- Implement the async variant of toEventually using structured
concurrency by [@&#8203;younata](https://togithub.com/younata) in
[Quick/Nimble#1079
- Fix all swiftlint warnings by
[@&#8203;younata](https://togithub.com/younata) in
[Quick/Nimble#1085

**Full Changelog**:
Quick/Nimble@v12.2.0...v12.3.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi45Ni4wIiwidXBkYXRlZEluVmVyIjoiMzYuOTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant