Fix equal compilation optionals #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessesquires
approved these changes
Apr 20, 2022
younata
force-pushed
the
fix-equal-compilation-optionals
branch
from
5687d81
to
6b0e5df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends and solves #962 by doing what @ikesyo suggests as the fix.
Another possible fix would be to add public extensions of Array, Set, and Dictionary such that they can also use
==or!=with Optionals. I elected not to do that because I'd rather not change the behavior of these very common types just for Nimble. It felt way less riskier to bring back these matchers.Maybe in the future, Swift will be enhanced again so that we can actually simplify these matchers.
Thanks @acecilia for bringing up this issue!