Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hardcoded expectation result #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix hardcoded expectation result #5

wants to merge 1 commit into from

Conversation

chrisamanse
Copy link

@chrisamanse chrisamanse commented May 19, 2017

  • What behavior was changed?
    beGreaterThan, beGreaterThanOrEqualTo, and beLessThanOrEqual have hardcoded expectation result, which results in an error if the type of ExpectationResult changes.

  • What code was refactored / updated to support this change?
    The files corresponding to each matcher.

  • What issues are related to this PR? Or why was this change introduced?
    Tried replacing type of ExpectationResult to String since colors don't show preview in my Xcode (Xcode 8.3).

  • Does this have tests?
    Can't create a test since the type of ExpectationResult is set at compile time.

  • Does this have documentation?

  • Does this break the public API (Requires major version bump)?

  • Is this a new feature (Requires minor version bump)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant