Fix hardcoded expectation result #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What behavior was changed?
beGreaterThan,beGreaterThanOrEqualTo, andbeLessThanOrEqualhave hardcoded expectation result, which results in an error if the type ofExpectationResultchanges.What code was refactored / updated to support this change?
The files corresponding to each matcher.
What issues are related to this PR? Or why was this change introduced?
Tried replacing type of
ExpectationResulttoStringsince colors don't show preview in my Xcode (Xcode 8.3).Does this have tests?
Can't create a test since the type of ExpectationResult is set at compile time.
Does this have documentation?
Does this break the public API (Requires major version bump)?
Is this a new feature (Requires minor version bump)?