-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to tell sherif to ignore peerDepedencies #61
Comments
You can use It was requested in #49 but I'm actually not sure if we should keep it or not. |
Maybe a config option? I feel like this would be a common requirement. Maybe even make checking peerDependency opt in? I think it's the norm, especially in repos for npm packages, to have a different version specifyer than an exact version in the peerDependency fields. |
One of the goal of this project is to avoid as much as possible for users the need to use cli options, or to introduce a configuration file. But I agree with you that Sherif should be smarter here, and not error. |
Yes, this rule is problematic and IMO wrong. When you define peers, you typically want to specify the version using a caret, e.g. And then you want to install the exact pinned version ( Currently, sherif will flag it as an issue.
|
Sorry for the delay, I reverted #49 and released https://github.com/QuiiBz/sherif/releases/tag/v0.8.4 |
Just upgraded to the latest version of sherif. How can we tell sherif to ignore the versions of peer dependencies? They should not be considered IMO.
The text was updated successfully, but these errors were encountered: