fix: allow eslint to accept FunctionComponent as valid inside lexical…

… scopes (#4900) fix #4794
QwikDev · Aug 23, 2023 · b593a3c · b593a3c
1 parent d76b20e
commit b593a3c
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -105,6 +105,7 @@
     "build": "tsm scripts/index.ts --tsc --build --qwikcity --qwiklabs --api --platform-binding-wasm-copy",
     "build.cli": "tsm scripts/index.ts --cli --dev",
     "build.cli.prod": "tsm scripts/index.ts --cli",
+    "build.eslint": "tsm scripts/index.ts --eslint",
     "build.full": "tsm scripts/index.ts --tsc --build --supabaseauthhelpers --api --eslint --qwikcity --qwikworker --qwiklabs --qwikreact --qwikauth --cli --platform-binding --wasm",
     "build.only_javascript": "tsm scripts/index.ts --tsc --build --api",
     "build.platform": "tsm scripts/index.ts --platform-binding",

diff --git a/packages/eslint-plugin-qwik/qwik.unit.ts b/packages/eslint-plugin-qwik/qwik.unit.ts
@@ -360,7 +360,6 @@ export const RemoteApp = component$(({ name }: { name: string }) => {
               console.log(a);
             }}></div>;
           });`,
-
     `
   export interface PropFnInterface<ARGS extends any[], RET> {
     (...args: ARGS): Promise<RET>
@@ -386,7 +385,6 @@ export const RemoteApp = component$(({ name }: { name: string }) => {
     }}></div>;
   });
       `,
-    ``,
     `
 import { component$ } from "@builder.io/qwik";
 
@@ -427,6 +425,29 @@ export default component$(() => {
             useMethod(foo);
             return <div></div>
           });`,
+    `
+      import {Component, component$, useStore} from '@builder.io/qwik';
+      export const PopupManager = component$(() => {
+        const popup = useStore({
+            component: null as null | Component<any>,
+            props: null as any,
+            visible: false,
+            x: 0,
+            y: 0,
+        });
+        return (
+            <div
+                document:onMouseEnter$={(e) => {
+                popup.visible = true;
+            }}
+                document:onMouseLeave$={(e) => {
+                popup.visible = true;
+            }}
+            >
+            </div>
+        );
+      });
+    `,
   ],
   invalid: [
     {

diff --git a/packages/eslint-plugin-qwik/src/validLexicalScope.ts b/packages/eslint-plugin-qwik/src/validLexicalScope.ts
@@ -338,7 +338,8 @@ function _isTypeCapturable(
     if (
       symbolName === 'PropFnInterface' ||
       symbolName === 'RefFnInterface' ||
-      symbolName === 'bivarianceHack'
+      symbolName === 'bivarianceHack' ||
+      symbolName === 'FunctionComponent'
     ) {
       return;
     }