-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:consistent type imports warning #2647
Conversation
|
Thanks @harshmangalam for taking the time to create this PR 🙏 |
Vs code warn when we import type without type keyword. |
Your eslint is disabled hence you are not getting any warning. |
Thanks again for your feedback 🙏 My eslint is working and reports all issues as it should except the one you refer here 🙈 these presets are defined and as far as i can see non of them have the rule included 🙈 (pls correct me if i am wrong 🙏 )
can it be, that you use a global version of eslint in vscode which uses another config file?
would be very interested to hear what the outcome of this is 🙏 thanks again for your help! |
@zanettin got your points. |
Hi @harshmangalam |
Hey I follow your process now everything is working fine. |
So glad to hear 🙏 Thanks anyways for creating this PR and doing the debugging! hope to see soooonish another PR from you 😃 |
What is it?
Description
fix consistent type import warning