Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pr local dev docker #5237

Merged
merged 3 commits into from
Oct 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,12 +1,15 @@
FROM cimg/rust:1.65.0-node
FROM cimg/rust:1.72.1-node

RUN rustup toolchain install nightly-2022-09-23; \
rustup default nightly-2022-09-23; \
rustup --version; \
RUN rustup --version; \
cargo --version; \
rustc --version; \
rustup update; \
rustc --version;

RUN rustup update; \
rustup target add wasm32-unknown-unknown; \
cargo install cargo-insta wasm-pack; \
cargo install cargo-insta; \
cargo install wasm-pack; \
rustup component add clippy; \
corepack enable --install-directory ~/bin

RUN mkdir /home/circleci/store; \
pnpm config set store-dir /home/circleci/store
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ You need to have these tools up and running in your local machine:

If you would like to make use of the devlopment container solution, but don't use VSCode or Dev Containers, you still can do so, by following steps:

- Build development container locally: `cd .devcontainers; docker build -t qwik-container .`
- Build development container locally: `cd .devcontainer; docker build -t qwik-container .`
- Run development container from Qwik project root, binding the directory to container: `cd ..; docker run --rm -d --name qwik-container -p 3300:3300 -p 9229:9299 -v $PWD:/home/circleci/project -t qwik-container`

Docker command does:
Expand Down
Loading