chore: ts-ignore vite 5 types issue #5341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for qwik-insights pending review.Visit the deploys page to approve it
|
kodiakhq bot
pushed a commit
to ascorbic/unpic-img
that referenced
this pull request
Oct 29, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@builder.io/qwik](https://qwik.builder.io/) ([source](https://togithub.com/BuilderIO/qwik)) | [`1.2.14` -> `1.2.15`](https://renovatebot.com/diffs/npm/@builder.io%2fqwik/1.2.14/1.2.15) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>BuilderIO/qwik (@​builder.io/qwik)</summary> ### [`v1.2.15`](https://togithub.com/BuilderIO/qwik/releases/tag/v1.2.15) [Compare Source](https://togithub.com/BuilderIO/qwik/compare/v1.2.14...v1.2.15) #### What's Changed - fix(vercel): \[vercel-edge adapter] allow to use the `node` target by [@​Schniz](https://togithub.com/Schniz) in [QwikDev/qwik#4361 - refactor(optimizer): remove using resolvePackageData API from Vite by [@​bluwy](https://togithub.com/bluwy) in [QwikDev/qwik#5312 - feat: add outDir support to qwikInsights by [@​intellix](https://togithub.com/intellix) in [QwikDev/qwik#5335 - fix(cli): set args on interactive cli by [@​mpeg](https://togithub.com/mpeg) in [QwikDev/qwik#5334 - chore: ts-ignore vite 5 types issue by [@​bluwy](https://togithub.com/bluwy) in [QwikDev/qwik#5341 - chore(docs): remove warnings by [@​gioboa](https://togithub.com/gioboa) in [QwikDev/qwik#5345 - style(eslint): convey a stricter restriction from `just` to `only` (examples) by [@​uceumice](https://togithub.com/uceumice) in [QwikDev/qwik#5340 - feat(vite): allow disabling dev SSR server in vite by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5347 - chore(docs): Small fix of file to edit by [@​nelsonprsousa](https://togithub.com/nelsonprsousa) in [QwikDev/qwik#5348 - docs: Update index.mdx by [@​runarj](https://togithub.com/runarj) in [QwikDev/qwik#5351 - fix: action redirect accidentally stripped searchparams by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5349 - fix: remove cf pages stream polyfill by [@​mpeg](https://togithub.com/mpeg) in [QwikDev/qwik#5352 - chore: updated twitter logo to X by [@​Kaushik080](https://togithub.com/Kaushik080) in [QwikDev/qwik#5357 - docs: update React cheat sheet title by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5358 - chore: 1.2.15 by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5359 #### New Contributors - [@​Schniz](https://togithub.com/Schniz) made their first contribution in [QwikDev/qwik#4361 - [@​bluwy](https://togithub.com/bluwy) made their first contribution in [QwikDev/qwik#5312 - [@​intellix](https://togithub.com/intellix) made their first contribution in [QwikDev/qwik#5335 - [@​nelsonprsousa](https://togithub.com/nelsonprsousa) made their first contribution in [QwikDev/qwik#5348 - [@​Kaushik080](https://togithub.com/Kaushik080) made their first contribution in [QwikDev/qwik#5357 **Full Changelog**: QwikDev/qwik@v1.2.14...v1.2.15 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 9pm on sunday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ascorbic/unpic-img). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMS41IiwidXBkYXRlZEluVmVyIjoiMzcuMzEuNSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What is it?
Description
Currently Qwik in vite-ecosystem-ci is failing in the build step as Vite 5 has removed the
ssr.formatoption. This PR fixes it by adding@ts-ignoreso it works in both Vite 4 and Vite 5.Use cases and why
There are a few more PRs coming to Vite 5, and being able to make Qwik green allows us to anticipate potential breaking changes better.
Checklist: