fix(routing): fallback to hard navigation when soft navigation fails.

.envrc

@@ -0,0 +1,2 @@
+use flake
+PATH_add ./node_modules/.bin

.github/workflows/ci.yml

@@ -31,6 +31,8 @@ jobs:
     runs-on: ubuntu-latest
     outputs:
       fullbuild: ${{ steps.filter.outputs.fullbuild == 'true' || github.event.inputs.disttag != '' }}
+      insightsbuild: ${{ steps.filter_insights.outputs.insightsbuild == 'true' || github.event.inputs.disttag != '' }}
+      docsbuild: ${{ steps.filter_docs.outputs.docsbuild == 'true' || github.event.inputs.disttag != '' }}
 
     steps:
       - name: Cancel Previous Runs
@@ -66,9 +68,24 @@ jobs:
               - 'Cargo.yaml'
               - '.github/workflows/*.yaml'
               - 'scripts/*.ts'
+      - uses: dorny/paths-filter@v2
+        id: filter_insights
+        with:
+          filters: |
+            insightsbuild:
+              - 'packages/insights/**/*'
+      - uses: dorny/paths-filter@v2
+        id: filter_docs
+        with:
+          filters: |
+            docsbuild:
+              - 'packages/docs/**/*'
+
       - name: Print variables output
         run: |
           echo fullbuild=${{ steps.filter.outputs.fullbuild }}
+          echo insightsbuild=${{ steps.filter_insights.outputs.insightsbuild }}
+          echo docsbuild=${{ steps.filter_docs.outputs.docsbuild }}
           echo disttag=${{ github.event.inputs.disttag }}
           echo event_name=${{ github.event_name }}
 
@@ -92,16 +109,19 @@ jobs:
       - run: corepack enable
 
       - name: Install NPM Dependencies
-        run: pnpm install --frozen-lockfile
+        run: |
+          # Ensure that the qwik binary gets made
+          mkdir -p packages/qwik/dist/bindings/
+          pnpm install --frozen-lockfile
 
       - name: Build Packages
-        run: pnpm tsm scripts/index.ts --tsc --build --cli --api --set-dist-tag="${{ github.event.inputs.disttag }}"
+        run: pnpm tsm scripts/index.ts --tsc --build --cli --api --qwiklabs --eslint --platform-binding-wasm-copy --set-dist-tag="${{ github.event.inputs.disttag }}"
 
       - name: Print Qwik Dist Build
         run: tree packages/qwik/dist/
 
       - name: Upload Qwik Build Artifacts
-        uses: actions/upload-artifact@master
+        uses: actions/upload-artifact@v3
         with:
           name: dist-dev-builder-io-qwik
           path: packages/qwik/dist/
@@ -111,7 +131,7 @@ jobs:
         run: tree packages/create-qwik/dist/
 
       - name: Upload Create Qwik CLI Build Artifacts
-        uses: actions/upload-artifact@master
+        uses: actions/upload-artifact@v3
         with:
           name: dist-dev-create-qwik
           path: packages/create-qwik/dist/
@@ -124,7 +144,7 @@ jobs:
         run: tree packages/eslint-plugin-qwik/dist/
 
       - name: Upload Eslint rules Build Artifacts
-        uses: actions/upload-artifact@master
+        uses: actions/upload-artifact@v3
         with:
           name: dist-dev-eslint-plugin-qwik
           path: packages/eslint-plugin-qwik/dist/
@@ -186,7 +206,10 @@ jobs:
 
       - name: Install NPM Dependencies
         if: ${{ needs.changes.outputs.fullbuild == 'true' }}
-        run: pnpm install --frozen-lockfile
+        run: |
+          # Ensure that the qwik binary gets made
+          mkdir -p packages/qwik/dist/bindings/
+          pnpm install --frozen-lockfile
 
       - uses: jetli/wasm-pack-action@v0.3.0
         if: ${{ needs.changes.outputs.fullbuild == 'true' }}
@@ -203,7 +226,7 @@ jobs:
 
       - name: Upload WASM Build Artifacts
         if: ${{ needs.changes.outputs.fullbuild == 'true' }}
-        uses: actions/upload-artifact@master
+        uses: actions/upload-artifact@v3
         with:
           name: dist-bindings-wasm
           path: packages/qwik/dist/bindings/*
@@ -294,7 +317,10 @@ jobs:
 
       - name: Install NPM Dependencies
         if: ${{ needs.changes.outputs.fullbuild == 'true' }}
-        run: pnpm install --frozen-lockfile
+        run: |
+          # Ensure that the qwik binary gets made
+          mkdir -p packages/qwik/dist/bindings/
+          pnpm install --frozen-lockfile
 
       - name: Build Platform Binding
         if: ${{ needs.changes.outputs.fullbuild == 'true' }}
@@ -309,6 +335,72 @@ jobs:
           path: packages/qwik/dist/bindings/*.node
           if-no-files-found: error
 
+  ############ BUILD INSIGHTS ############
+  build-insights:
+    name: Build Insights
+    needs: changes
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout
+        if: ${{ needs.changes.outputs.insightsbuild == 'true' }}
+        uses: actions/checkout@v3
+
+      - uses: pnpm/action-setup@v2.2.4
+        if: ${{ needs.changes.outputs.insightsbuild == 'true' }}
+
+      - name: Setup Node
+        if: ${{ needs.changes.outputs.insightsbuild == 'true' }}
+        uses: actions/setup-node@v3
+        with:
+          node-version: 18.x
+          cache: 'pnpm'
+          registry-url: https://registry.npmjs.org/
+
+      - name: Install NPM Dependencies
+        if: ${{ needs.changes.outputs.insightsbuild == 'true' }}
+        run: |
+          # Ensure that the qwik binary gets made
+          mkdir -p packages/qwik/dist/bindings/
+          pnpm install --frozen-lockfile
+
+      - name: Build Qwik Insights
+        if: ${{ needs.changes.outputs.insightsbuild == 'true' }}
+        run: pnpm run build.packages.insights
+
+  ############ BUILD DOCS ############
+  build-docs:
+    name: Build Docs
+    needs: changes
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout
+        if: ${{ needs.changes.outputs.docsbuild == 'true' }}
+        uses: actions/checkout@v3
+
+      - uses: pnpm/action-setup@v2.2.4
+        if: ${{ needs.changes.outputs.docsbuild == 'true' }}
+
+      - name: Setup Node
+        if: ${{ needs.changes.outputs.docsbuild == 'true' }}
+        uses: actions/setup-node@v3
+        with:
+          node-version: 18.x
+          cache: 'pnpm'
+          registry-url: https://registry.npmjs.org/
+
+      - name: Install NPM Dependencies
+        if: ${{ needs.changes.outputs.docsbuild == 'true' }}
+        run: |
+          # Ensure that the qwik binary gets made
+          mkdir -p packages/qwik/dist/bindings/
+          pnpm install --frozen-lockfile
+
+      - name: Build Qwik Docs
+        if: ${{ needs.changes.outputs.docsbuild == 'true' }}
+        run: pnpm run build.packages.docs
+
   ############ BUILD DISTRIBUTION ############
   build-distribution:
     name: Build Distribution
@@ -342,13 +434,11 @@ jobs:
         if: ${{ needs.changes.outputs.fullbuild == 'true' }}
 
       - name: Install NPM Dependencies
-        if: ${{ needs.changes.outputs.fullbuild == 'true' }}
-        run: pnpm install --frozen-lockfile
-
-      - name: Create packages/qwik/dist/ directory
         if: ${{ needs.changes.outputs.fullbuild == 'true' }}
         run: |
+          # Ensure that the qwik binary gets made
           mkdir -p packages/qwik/dist/bindings/
+          pnpm install --frozen-lockfile
 
       - name: Download Build Artifacts
         if: ${{ needs.changes.outputs.fullbuild == 'true' }}
@@ -376,23 +466,23 @@ jobs:
 
       - name: Upload Qwik Distribution Artifact
         if: ${{ needs.changes.outputs.fullbuild == 'true' }}
-        uses: actions/upload-artifact@master
+        uses: actions/upload-artifact@v3
         with:
           name: builderio-qwik-distribution
           path: packages/qwik/dist/*
           if-no-files-found: error
 
       - name: Build QwikCity / QwikLabs
         if: ${{ needs.changes.outputs.fullbuild == 'true' }}
-        run: pnpm tsm scripts/index.ts --tsc --qwikcity --qwiklabs --api
+        run: pnpm tsm scripts/index.ts --tsc --qwikcity --qwiklabs --api --eslint
 
       - name: Print QwikCity Lib Build
         if: ${{ needs.changes.outputs.fullbuild == 'true' }}
         run: tree packages/qwik-city/lib/
 
       - name: Upload QwikCity Build Artifacts
         if: ${{ needs.changes.outputs.fullbuild == 'true' }}
-        uses: actions/upload-artifact@master
+        uses: actions/upload-artifact@v3
         with:
           name: builderio-qwikcity-distribution
           path: packages/qwik-city/lib/
@@ -404,7 +494,7 @@ jobs:
 
       - name: Upload QwikLabs Build Artifacts
         if: ${{ needs.changes.outputs.fullbuild == 'true' }}
-        uses: actions/upload-artifact@master
+        uses: actions/upload-artifact@v3
         with:
           name: builderio-qwiklabs-distribution
           path: |
@@ -464,7 +554,10 @@ jobs:
           mv builderio-qwiklabs-distribution/vite/* packages/qwik-labs/vite/
 
       - name: Install NPM Dependencies
-        run: pnpm install --frozen-lockfile
+        run: |
+          # Ensure that the qwik binary gets made
+          mkdir -p packages/qwik/dist/bindings/
+          pnpm install --frozen-lockfile
 
       - name: Commit Build Artifacts
         if: ${{ needs.changes.outputs.fullbuild == 'true' && github.event_name == 'push' }}
@@ -543,7 +636,10 @@ jobs:
 
       - name: Install NPM Dependencies
         if: ${{ needs.changes.outputs.fullbuild == 'true' }}
-        run: pnpm install --frozen-lockfile
+        run: |
+          # Ensure that the qwik binary gets made
+          mkdir -p packages/qwik/dist/bindings/
+          pnpm install --frozen-lockfile
 
       - name: Install Playwright
         if: ${{ needs.changes.outputs.fullbuild == 'true' }}
@@ -580,7 +676,13 @@ jobs:
       - run: corepack enable
 
       - name: Install NPM Dependencies
-        run: pnpm install --frozen-lockfile
+        run: |
+          # Ensure that the qwik binary gets made
+          mkdir -p packages/qwik/dist/bindings/
+          pnpm install --frozen-lockfile
+
+      - name: Build core
+        run: pnpm run build.core
 
       - name: Unit Tests
         run: pnpm run test.unit
@@ -670,12 +772,19 @@ jobs:
       - run: corepack enable
 
       - name: Install NPM Dependencies
-        run: pnpm install --frozen-lockfile
+        run: |
+          # Ensure that the qwik binary gets made
+          mkdir -p packages/qwik/dist/bindings/
+          pnpm install --frozen-lockfile
 
       - name: Prettier Check
         if: ${{ always() }}
         run: pnpm run lint.prettier
 
+      - name: Build ESLint
+        if: ${{ always() }}
+        run: pnpm tsm scripts/index.ts --eslint
+
       - name: ESLint Check
         if: ${{ always() }}
         run: pnpm run lint.eslint

.gitignore

@@ -7,6 +7,7 @@
 etc
 temp
 .history
+.lh
 *.
 **/*.log
 *.node
@@ -16,6 +17,7 @@ qwik-app/
 /server/
 /starters/**/server/
 /packages/*/server/
+!/packages/qwik/server/
 /packages/*/src/styled-system/
 todo-express/
 target
@@ -37,6 +39,7 @@ tsdoc-metadata.json
 .idea
 .eslintcache
 test-results
+.direnv
 
 # Package Managers
 .yarn/*
@@ -45,3 +48,4 @@ test-results
 
 # Local Netlify folder
 .netlify
+sandbox

.nvmrc

@@ -1 +1 @@
-18.11
+20.11

.vscode/launch.json

@@ -13,6 +13,15 @@
       "program": "${workspaceFolder}/packages/docs/node_modules/vite/bin/vite.js",
       "args": ["--mode", "ssr", "--force"]
     },
+    {
+      "type": "node",
+      "name": "insights dev.debug",
+      "request": "launch",
+      "skipFiles": ["<node_internals>/**"],
+      "cwd": "${workspaceFolder}/packages/insights",
+      "program": "${workspaceFolder}/packages/insights/node_modules/vite/bin/vite.js",
+      "args": ["--mode", "ssr", "--force"]
+    },
     {
       "type": "node",
       "name": "docs build.client",
@@ -49,7 +58,7 @@
       "internalConsoleOptions": "neverOpen",
       "program": "${workspaceFolder}/./node_modules/vitest/vitest.mjs",
       "cwd": "${workspaceFolder}",
-      "args": ["--threads=false", "packages/qwik/src/core/container/render.unit.tsx"]
+      "args": ["--threads=false", "${file}"]
     }
   ]
 }

CONTRIBUTING.md

@@ -22,7 +22,7 @@ We adopt [trunk-based development](https://trunkbaseddevelopment.com/) therefore
 
 ### Good first issue
 
-The issues marked with [_Good first issue_](https://github.com/BuilderIO/qwik/issues?q=is:open+is:issue+label:%22good+first+issue%22) are a good starting point to familiarize yourself with the project.
+The issues marked with [_Good first issue_](https://github.com/BuilderIO/qwik/issues?q=is%3Aissue+is%3Aopen+label%3A%22COMMUNITY%3A++good+first+issue%22) are a good starting point to familiarize yourself with the project.
 
 Before solving the problem, please check with the maintainers that the issue is still relevant. Feel free to leave a comment on the issue to show your intention to work on it and prevent other people from unintentionally duplicating your effort.
 
@@ -61,16 +61,28 @@ This is the best approach because all required dependencies will be installed in
 You need to have these tools up and running in your local machine:
 
 - [VSCode](https://code.visualstudio.com/)
-- [Docker](https://www.docker.com/)
+
+and either [Docker](https://www.docker.com/) or [Nix](https://nixos.org).
 
 ### Steps
 
+If you want to use Docker:
+
 - Install the [Dev Containers](https://marketplace.visualstudio.com/items?itemName=ms-vscode-remote.remote-containers) extension in your VSCode.
 - Once installed you will be prompted to 'Reopen the folder to develop in a container [learn more](https://code.visualstudio.com/docs/devcontainers/containers) or Clone repository in Docker volume for [better I/O performance](https://code.visualstudio.com/docs/devcontainers/containers#_quick-start-open-a-git-repository-or-github-pr-in-an-isolated-container-volume)'. If you're not prompted, you can run the `Dev Containers: Open Folder in Container` command from the [VSCode Command Palette](https://code.visualstudio.com/docs/getstarted/userinterface#_command-palette).
 
+If you want to use Nix:
+
+- Install [Nix](https://nixos.org/download.html) on your machine and enable flakes. The [DetSys installer](https://github.com/DeterminateSystems/nix-installer) makes that easy.
+- run `nix develop` in the project root.
+
+Nix+Direnv (optional):
+
+You can additionally use [direnv](https://direnv.net/) to automatically load the dev environment when you enter the project directory.
+
 ### Using development container without Dev Containers and VSCode
 
-If you would like to make use of the devlopment container solution, but don't use VSCode or Dev Containers, you still can do so, by following steps:
+If you would like to make use of the development container solution, but don't use VSCode or Dev Containers, you still can do so, by following steps:
 
 - Build development container locally: `cd .devcontainer; docker build -t qwik-container .`
 - Run development container from Qwik project root, binding the directory to container: `cd ..; docker run --rm -d --name qwik-container -p 3300:3300 -p 9229:9299 -v $PWD:/home/circleci/project -t qwik-container`