fix(routing): fallback to hard navigation when soft navigation fails. #5521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for qwik-insights pending review.Visit the deploys page to approve it
|
|
I like it, but I wonder:
For the second question, I'm thinking that it's probably ok because the user can reload the page at all times. |
|
I'm concerned about the other cases where
|
* chore(cf): Fix CloudFlare build failure * chore(cf): Fix CloudFlare build failure
* chore(cf): Fix CloudFlare build failure * chore(cf): Fix CloudFlare build failure * fixup! chore(cf): Fix CloudFlare build failure
…ebsite (QwikDev#5523) * Update pages.json with my personal wbesite Add my personal website, which includes a blog section that fetches data from Prismic CMS * fixup! Update pages.json with my personal wbesite --------- Co-authored-by: Miško Hevery <misko@hevery.com>
I changed the file pathes in the docs to match the real ones and also added a prei18n-extract script to make sure the build is running before the extract. I guess a lot of users will miss that one.
The new vite-imagetools version uses a newer Sharp version which will allow Qwik City to work with Deno denoland/deno#20612
* 🎾 * ⛳️ * tailwind * 🪂 * 🎱 * 🖖 * 📦 * 📫 * 🐼👋 * manifests ✅ * routes index ✅ * route detail ✅ * symbols ✅ * edges ✅ * bundles ✅ * slow symbols ✅ * error ✅ * 📫 * 📊 * popup manager ✅ * correlation & popups ✅ * ⏱️ * fix: colspan => colSpan --------- Co-authored-by: Miško Hevery <misko@hevery.com>
Specifics:
- piggyback on TS HTML types as much as possible (now automatically supports new props like popover)
- Remove QwikEvents and SyntheticEvents, they are really just DOM events
- improve QRL and QRLInternal types for better matching
- useOn* now can infer type and the passed element is also typed
- move the QRL AbortSignal to server$, the only place where it's supported
- generic parameter to useDocumentHead for the frontmatter
- DOM ref={} functions get the type of the element
Generic:
- add some tests for the types
- use `unknown` or actual type instead of `any` where possible
- if not used as part of an `extends` test, it's probably ok to change `any` to `unknown`. It will surface type mismatches.
- fix function signatures so they can match extends ( `(...args: any) => any` instead of `(...args: any[]) => any`
- change some interfaces to types if they're not meant to be merge-extended and they're not extending (interfaces have a performance advantage there)
- add jsdoc comments
Actual code changes:
- In use-task.ts, allow `track(signal)` inside a task
- in docs, remove useless filtering from class array
- changed some hardcoded strings to constants
for some reason it is not visible unless it's a dev dependency
* add created/updated date to docs frontmatter * read the frontmatter (QwikDev#1) * feat: show updated docs showing the updated docs with a circle next to the title, in this commit I added the circles. * chore(docs): remove warnings (QwikDev#5345) * style(eslint): convey a stricter restriction from `just` to `only` (examples) (QwikDev#5340) * feat(vite): allow disabling dev SSR server in vite (QwikDev#5347) * chore(docs): Small fix of file to edit (QwikDev#5348) * docs: Update index.mdx (QwikDev#5351) * Update index.mdx Correct mistake. The original was: Both pages are created by adding ... Changed to: Pages are created by adding ... * trigger GH checks --------- Co-authored-by: gioboa <giorgiob.boa@gmail.com> * fix: action redirect accidentally stripped searchparams (QwikDev#5349) Fix QwikDev#5342 * fix: remove cf pages stream polyfill (QwikDev#5352) * chore: updated twitter logo to X (QwikDev#5357) * docs: update React cheat sheet title (QwikDev#5358) * 1.2.15 (QwikDev#5359) * docs: improve SEO with descriptions (QwikDev#5360) * fix(cli): parseTemplatePath doesn't work in windows (QwikDev#5339) * fix(cli) parseTemplatePath doesn't work in windows * refactor use path.sep --------- Co-authored-by: Yale <yale.yu@kuka.com> * docs: fix typo (QwikDev#5361) * chore(qwik-insights): use clientOutDir if provided (QwikDev#5366) * docs: remove soundy.cloud (QwikDev#5374) * chore: clean up release script (QwikDev#5376) * fix(qwik): Incorrect module reference in inlinedQrl (QwikDev#5375) * fix(qwik): Incorrect module reference in inlinedQrl Fix QwikDev#5368 * fixup! fix(qwik): Incorrect module reference in inlinedQrl * docs: Alex Russell Approved javascript framework (QwikDev#5364) * docs: Alex Russell Approved Alex Russell Approved JavaScript framework * docs(faq): wording * chore: improved README.md for build artifacts (QwikDev#5377) * fix(qwik-city): parseBody should not clone Request (QwikDev#5353) fix(qwik-city): parseBody should not clone requests * docs(eslint-rules): refactor use-method-usage to reflect current qwik… (QwikDev#5344) * docs(eslint-rules): refactor use-method-usage to reflect current qwik API * refactored unit tests * re-add TSAsExpression * word change: just -> only, to reflect latest PR --------- Co-authored-by: Miško Hevery <misko@hevery.com> * fix: Yarn 3/4 PnP compatibility (QwikDev#5042) * CI * revert --------- Co-authored-by: Roman Zanettin <roman.zanettin@gmail.com> * Revert "refactor(optimizer): remove using resolvePackageData API from Vite" (QwikDev#5379) Revert "refactor(optimizer): remove using resolvePackageData API from Vite (QwikDev#5312)" This reverts commit ec53ef7. * docs: update Alex Russell (QwikDev#5381) * chore: 1.2.16 (QwikDev#5382) * fix(labs): Better handling and visibility of q-insights.json (QwikDev#5384) * feat(insights): Add new route visibility (QwikDev#5385) * fix(vite): resolution of nested dependencies Co-authored-by: Manu MA <manucorporat@users.noreply.github.com> * docs: fix incorrect escaping in URL (QwikDev#5387) * fix(insights): improve files per cluster (QwikDev#5388) Increase clustering distance which should result in creation of fewer clusters. Fewer clusters means that less files should be downloaded to the client (each file will have more symbols.) This should improve performance. * fix(qwik): Improve logging of vite plugin (QwikDev#5389) fix(qwik): Improve logging of vite plugin The log now includes file location and code snippet. * fix(core): parent component lookup during pause the parentCtx attribute was optimized to point directly to parents with $contexts$ defined, but that broke pausing which needs the immediate parent. Co-authored-by: Jesse Zhang <jesse.zhang@orchard.com> * chore: clean up docs site build warnings (QwikDev#5391) * docs: explain custom event props and detail when PropFunction is needed (QwikDev#5386) * docs: don't index demos; don't duplicate meta descriptions (QwikDev#5392) * docs: add custom 404 page (QwikDev#5393) * chore(docs): small improvements to routing/index.mdx * refactor(package.json): add docs.dev & docs.preview Add pnpm docs.dev & pnpm docs.preview commands to improve the DX for contributors. * chore: 1.2.17 (QwikDev#5397) * fix(insight): use relative path (QwikDev#5399) * docs: Update media page with new YouTube video links (QwikDev#5401) Update media page with new YouTube video links * chore(starters): add VSCode debug setting (QwikDev#5408) * docs(integrations): astro integration docs (QwikDev#5409) * docs(integrations): astro integration docs * docs(integration): typo * docs(docs): updated docs changes * docs(menu): Add Astro integration to menu (QwikDev#5410) * Add Astro integration to menu * Add description and keywords to Astro integration page, and update contributor list. * chore(docs): update node integration page (QwikDev#5413) Bold statement regarding `ORIGIN` env var. * fix(qwik-city): vercel adapter default to `webworker` target (QwikDev#5414) * docs: correct broken image (QwikDev#5415) * docs(astro): Qwik + Astro doc improvements (QwikDev#5416) * Qwik astro doc improvements * typo fix * fix(propfunctionprops): prevent 'undefined', 'null', 'never' conversion to PropFnInterface (QwikDev#5363) * fix(propfunctionprops): prevent 'undefined', 'null', 'never' conversion to PropFnInterface fix QwikDev#4946 * improve PropFunctionProps readability and edge-cases * fix never becoming undefined * fixup! fix never becoming undefined * refine tests --------- Co-authored-by: Miško Hevery <misko@hevery.com> * fix(qwik-city): better type for svg?jsx imports (QwikDev#5420) * fix(qwik-city): fix rendered svg?jsx component closing tag (QwikDev#5423) * fix: fix optimized svg closing tag * test: add svg optimizer test * fix: cache max-age vite.config for dev mode (QwikDev#5427) * fix(cli): casing for component and mdx route creation (QwikDev#5430) * docs: fix broken image (QwikDev#5432) * docs: fixed small typo (QwikDev#5434) * docs: add missing contributors (QwikDev#5435) * fix: 3rd party imports of libs during build (QwikDev#5431) Co-authored-by: Miško Hevery <misko@hevery.com> * fix(docs): improve SEO (QwikDev#5439) * feat(core): auto px addition to css properties for unitless numbers (QwikDev#5426) * feat(core): auto px addition to css properties for unitless numbers This adds support for auto-addition of 'px' to css properties * add tests to check styles in both ssr and csr * docs: Add link to create new Qwik Insights app as self-serve (QwikDev#5443) * fix: Pass the missing props for Spinner component (QwikDev#5437) Pass the missing props for Spinner component As the `growing` props is missing in the bootstrap starter template `Spinner` component it is causing the issue in production build while testing after adding the bootstrap. * fix(docs): Wrap function in cleanup function instead of returning it (QwikDev#5440) Wrap function in cleanup function instead of returning it * fix(docs): typo in qwikcity -> Validator docs (QwikDev#5444) --------- Co-authored-by: gioboa <giorgiob.boa@gmail.com> * fix(docs): typo in qwik city -> middleware page (QwikDev#5446) --------- Co-authored-by: gioboa <giorgiob.boa@gmail.com> * fix(docs): update links for Edit this page button (QwikDev#5445) --------- Co-authored-by: gioboa <giorgiob.boa@gmail.com> * chore: 1.2.18 (QwikDev#5449) * docs: Add Component library `ionic-qwik` to community projects on docs. (QwikDev#5429) Add Component library `ionic-qwik`. * chore(docs): advanced usage of Slot, visibleTask (QwikDev#5424) chore(docs): advanced Slot, visibleTask, Context * chore(core): update `QwikKeyboardEvent` type (QwikDev#5433) chore(core): update keyboardevent to have code attr and update deprecated attrs * fix(docs): remove `inline-code` and `link` in tag `<a />` (QwikDev#5450) --------- Co-authored-by: wangyipeng <ffwangyipeng@chinatelecom.cn> Co-authored-by: Giorgio Boa <35845425+gioboa@users.noreply.github.com> * docs(ssg): fix shell command (QwikDev#5459) * docs(auth.js): add credentials example (QwikDev#5462) * chore: 1.2.19 (QwikDev#5466) * chore(all): Vite 5 upgrade * chore(core): remove resolvePackageData (QwikDev#5312) * chore: pnpm api.update * feat(playground): remove broken versions * feat: add qwik/no-use-visible-task eslint rule (QwikDev#5455) * feat: add qwik/no-use-visible-task eslint rule ---- Co-authored-by: Matteo Pietro Dazzi <ilteoood@users.noreply.github.com> Co-authored-by: Pasquale De Lucia <pasquale.delucia96@gmail.com> Co-authored-by: Gloria Giannascoli <gloriag-dev@users.noreply.github.com> Co-authored-by: pietrodev07 <pietrodev07@users.noreply.github.com> * linter 🧽 * feat: add extra tips * fix: change message * docs: add missing eslint recap * chore(insights): remove unnecessary log (QwikDev#5461) * fix: add example context to docs (QwikDev#5467) * feat(qwik-city): allow customizing SVGO options of image plugin (QwikDev#5407) * docs: fix typo * docs: fix typo (QwikDev#5481) * fix(core): Support JSX in signals (QwikDev#5442) Fix QwikDev#4966 Fix QwikDev#3530 * docs(FAQ): - lazy-loading on user interaction & speculative module fetching (QwikDev#5488) docs: FAQ - lazy-loading on user interaction & speculative module fetching * docs(faq): add link to typescript (QwikDev#5487) * fix: disable Vite modulepreload (QwikDev#5493) * fix: disable Vite modulePreload Fixed: QwikDev#5478 * chore: use cleaner option * docs(faq): fix typos and improve the wording of some sentences (QwikDev#5490) * docs: make the distinction between module-prefetching and <Link prefetch> (QwikDev#5485) docs(module-prefetching): make the distinction between module-prefetching and <Link prefetch> * docs(showcase): add `index.app` and `wiza.co` (QwikDev#5484) Update pages.json * fix(docs): mdx interpreting title as component (QwikDev#5499) * docs: cleanup the vdom section (QwikDev#5500) * fix: revert "fix: remove cf pages stream polyfill" (QwikDev#5502) * fix(qwik-city): prefix ids of SVGs based on their path when loaded as qwik nodes (QwikDev#5497) Enable the prefixIds SVGO plugin by default, while still allowing customization. This is a follow up on QwikDev#5407. Here's a discussion on why it makes sense when optimizing SVG files for the web: svg/svgo#674. * fix: cf pages polyfill only if needed (QwikDev#5507) fix: polyfill only if needed * refactor: extract group type * docs: add QwikCityMockProvider explanation (QwikDev#5505) * Extend index.mdx to include QwikCityMockProvider * docs: add links between vitest integration page and qwikcity api page * docs(glob-import): add documentation for import.meta.glob (QwikDev#5504) * docs(glob-import): add documentation for import.meta.glob * docs(glob-imports): add Glob Import link to /cookbook/index.mdx * docs(glob-import): refactor type any to Record<string, any> * docs: add Record<string, any> to mdx as well * fix: CF pages polyfill also when shimmed (QwikDev#5512) * fix: polyfill also when shimmed * chore: add comment to explain polyfill * chore: Giorgio's feedback * refactor: made the renderUpdate as a const put the mardown update in a const which made the code cleaner and better to understand * fix: fixed build * docs: api update * refactor: build * chore: fix pnpm-locke file * chore: build * chore: pnpm fmt * refactor: removed style-system --------- Co-authored-by: Marcos Perona <mperona@gmail.com> Co-authored-by: Giorgio Boa <35845425+gioboa@users.noreply.github.com> Co-authored-by: Alex Tocar <commit@ueuie.dev> Co-authored-by: Miško Hevery <misko@hevery.com> Co-authored-by: Nelson Sousa <nelsonprsousa@gmail.com> Co-authored-by: Runar Jordahl <runar.jordahl@gmail.com> Co-authored-by: gioboa <giorgiob.boa@gmail.com> Co-authored-by: Kaushik080 <120493528+Kaushik080@users.noreply.github.com> Co-authored-by: Yoav Ganbar <hamatoyogi@users.noreply.github.com> Co-authored-by: yale.yu <35560398+yuyidegit@users.noreply.github.com> Co-authored-by: Yale <yale.yu@kuka.com> Co-authored-by: Bonny87 <36232591+mBonny87@users.noreply.github.com> Co-authored-by: D <intellix@users.noreply.github.com> Co-authored-by: PatrickJS <github@patrickjs.com> Co-authored-by: Maïeul <45822175+maiieul@users.noreply.github.com> Co-authored-by: Ian Létourneau <letourneau.ian@gmail.com> Co-authored-by: Roman Zanettin <roman.zanettin@gmail.com> Co-authored-by: Wout Mertens <Wout.Mertens@gmail.com> Co-authored-by: Manu MA <manucorporat@users.noreply.github.com> Co-authored-by: Jesse Zhang <jesse.zhang@orchard.com> Co-authored-by: maieulchevalier <maieul.chevalier@gmail.com> Co-authored-by: Jack Shelton <104264123+thejackshelton@users.noreply.github.com> Co-authored-by: Erik Eng <e.ptz0n@gmail.com> Co-authored-by: Steve Sewell <steve@builder.io> Co-authored-by: Riccardo Perra <perrariccardo0@gmail.com> Co-authored-by: Pasquale De Lucia <pasquale.delucia96@gmail.com> Co-authored-by: Sidharth Mohanty <sidmohanty11@gmail.com> Co-authored-by: Daniela Bonvini <danbonvini@gmail.com> Co-authored-by: Shai Reznik <shairez@users.noreply.github.com> Co-authored-by: Lucas Stahl <30933416+Stahlwalker@users.noreply.github.com> Co-authored-by: John Prem Kumar S <36818969+JohnPremKumar@users.noreply.github.com> Co-authored-by: Thomas Deinhamer <184284+thasmo@users.noreply.github.com> Co-authored-by: Harish Krishnan <harishkrishnan1993@gmail.com> Co-authored-by: Juer Genie Whang <2695996944@qq.com> Co-authored-by: Juer Genie Whang <juergenie@qq.com> Co-authored-by: wangyipeng <ffwangyipeng@chinatelecom.cn> Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com> Co-authored-by: Arjun <arjunsingh8112@gmail.com> Co-authored-by: Bendegúz Hajnal <hajnalbendeguz@gmail.com> Co-authored-by: ulic75 <ulic75@gmail.com> Co-authored-by: Youssef Adbib <mradbib@gmail.com> Co-authored-by: Necati <necatifk07@gmail.com> Co-authored-by: Leo <wtlin1228@gmail.com> Co-authored-by: mulztob <49060581+mulztob@users.noreply.github.com>
…NITY: good first issue"
- decouple symbol prefetch - don't add handlers when not needed Co-authored-by: Wout Mertens <Wout.Mertens@gmail.com>
wmertens
approved these changes
Jan 17, 2024
|
@iamriajul Could you rebase? The tests failed back then and I can't re-run them in this state, the rebase will trigger them. |
also extra tests for server function types
wmertens
removed
the
STATUS-2: PR waiting for review
|
Thanks! |
kodiakhq bot
pushed a commit
to ascorbic/unpic-img
that referenced
this pull request
Jan 30, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@builder.io/qwik](https://qwik.builder.io/) ([source](https://togithub.com/BuilderIO/qwik/tree/HEAD/packages/qwik)) | [`1.3.2` -> `1.4.3`](https://renovatebot.com/diffs/npm/@builder.io%2fqwik/1.3.2/1.4.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>BuilderIO/qwik (@​builder.io/qwik)</summary> ### [`v1.4.3`](https://togithub.com/BuilderIO/qwik/releases/tag/v1.4.3) [Compare Source](https://togithub.com/BuilderIO/qwik/compare/v1.4.2...v1.4.3) #### What's Changed - chore(vite): downgrade vite version by [@​balaji-sivasakthi](https://togithub.com/balaji-sivasakthi) in [QwikDev/qwik#5785 - fix(starter): adjust padding for 768px devices by [@​balaji-sivasakthi](https://togithub.com/balaji-sivasakthi) in [QwikDev/qwik#5787 - chore: lint++ by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5788 - fix(qwik-city): fix import ./[@​qwik-city](https://togithub.com/qwik-city) files in prod by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5791 - fix(qwik-auth): lock down `@auth/core` version by [@​balazsorban44](https://togithub.com/balazsorban44) in [QwikDev/qwik#5790 - chore(docs): align indentation by [@​greatgraphicdesign](https://togithub.com/greatgraphicdesign) in [QwikDev/qwik#5792 - chore(docs): Update to latest builder.io/sdk-qwik by [@​STRd6](https://togithub.com/STRd6) in [QwikDev/qwik#5794 - docs: Redirect all requests from builder.io to the qwik.dev domain. by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5796 - feat(QwikCityMockProvider): add optional goto prop by [@​alexismch](https://togithub.com/alexismch) in [QwikDev/qwik#5779 - chore(starters): update 🐼 PandaCSS integration starter dev dependency by [@​mrhoodz](https://togithub.com/mrhoodz) in [QwikDev/qwik#5797 - feat(qwik): configure sourcemap in optimizer by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5799 - chore: 1.4.3 by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5800 #### New Contributors - [@​balaji-sivasakthi](https://togithub.com/balaji-sivasakthi) made their first contribution in [QwikDev/qwik#5785 - [@​balazsorban44](https://togithub.com/balazsorban44) made their first contribution in [QwikDev/qwik#5790 - [@​greatgraphicdesign](https://togithub.com/greatgraphicdesign) made their first contribution in [QwikDev/qwik#5792 - [@​alexismch](https://togithub.com/alexismch) made their first contribution in [QwikDev/qwik#5779 **Full Changelog**: QwikDev/qwik@v1.4.2...v1.4.3 ### [`v1.4.2`](https://togithub.com/BuilderIO/qwik/releases/tag/v1.4.2) [Compare Source](https://togithub.com/BuilderIO/qwik/compare/v1.4.1...v1.4.2) ##### What's Changed - fix(docs): Sandbox playground iframe by [@​STRd6](https://togithub.com/STRd6) in [QwikDev/qwik#5768 - docs(astro): update integration doc by [@​thejackshelton](https://togithub.com/thejackshelton) in [QwikDev/qwik#5771 - docs: add note about Astro integrations order importance by [@​Seanmclem](https://togithub.com/Seanmclem) in [QwikDev/qwik#5776 - feat(dev): preload modules for / so dev starts faster by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5775 - fix: SW cache race condition by [@​thejackshelton](https://togithub.com/thejackshelton) in [QwikDev/qwik#5780 - chore: 1.4.2 by [@​thejackshelton](https://togithub.com/thejackshelton) in [QwikDev/qwik#5781 ##### New Contributors - [@​Seanmclem](https://togithub.com/Seanmclem) made their first contribution in [QwikDev/qwik#5776 **Full Changelog**: QwikDev/qwik@v1.4.1...v1.4.2 ### [`v1.4.1`](https://togithub.com/BuilderIO/qwik/releases/tag/v1.4.1) [Compare Source](https://togithub.com/BuilderIO/qwik/compare/v1.4.0...v1.4.1) ##### Overview - Try harder to prevent dirty tasks on SSR - AWS middleware in `qwik-city` - File filter option to make Qwik work better with Astro - `qwik-auth` can now handle multiple cookies - Node adapters in `qwik-city` now read .env files - Bugfixes in various service workers, starter CSS build, etc - Dependency updates Thanks to all contributors! ##### Commits - chore(starters): update 🐼 PandaCSS integration dev dependency by [@​mrhoodz](https://togithub.com/mrhoodz) in [QwikDev/qwik#5739 - docs: add Valibot website to showcases by [@​fabian-hiller](https://togithub.com/fabian-hiller) in [QwikDev/qwik#5740 - fix: multiple cookies in qwik-auth by [@​ksjogo](https://togithub.com/ksjogo) in [QwikDev/qwik#5602 - feat(qwik-city): AWS adapter middleware by [@​leifermendez](https://togithub.com/leifermendez) in [QwikDev/qwik#5732 - docs: fix code highlight by downgrading rehype-pretty-code by [@​Balastrong](https://togithub.com/Balastrong) in [QwikDev/qwik#5742 - feat(starters): add dotenv in node adapters by [@​hassanzohdy](https://togithub.com/hassanzohdy) in [QwikDev/qwik#5749 - fix(docs): Validate origin on postmessage by [@​STRd6](https://togithub.com/STRd6) in [QwikDev/qwik#5751 - feat(vite): new file filter option by [@​thejackshelton](https://togithub.com/thejackshelton) in [QwikDev/qwik#5752 - fix(ssr): dirty tasks by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5741 - fix(qwik): ensure that SW cache is properly opened by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5748 - fix: insights error handling and qwik-city json imports by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5754 - fix(prefetch-sw): await cache opening by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5759 - chore: updates by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5760 - fix(sw-prefetch): prevent uninitialized cache use by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5761 - fix(sw-prefetch): cache handling by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5764 - fix: duplicated css code in global.css in starter template by [@​linkfang](https://togithub.com/linkfang) in [QwikDev/qwik#5763 - feat(repl): use bundled qwik and prettier versions by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5755 - fix(sw-prefetch): clone on reuse by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5765 - chore: 1.4.1 by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5766 ##### New Contributors - [@​STRd6](https://togithub.com/STRd6) made their first contribution in [QwikDev/qwik#5751 **Full Changelog**: QwikDev/qwik@v1.4.0...v1.4.1 ### [`v1.4.0`](https://togithub.com/BuilderIO/qwik/releases/tag/v1.4.0) [Compare Source](https://togithub.com/BuilderIO/qwik/compare/v1.3.5...v1.4.0) ##### What's Changed - Types have changed a bit, now JSX components output `JSXOutput` instead of `JSXNode`, which captures the existing possibility to return strings, booleans, arrays etc. - The Link component now automatically prefetches the JS needed - When SPA routing fails, it will now use MPA routing as a fallback - Various bugfixes ##### PRs merged - docs(showcase): add Blueagle's Profolio & Blog by [@​blueagler](https://togithub.com/blueagler) in [QwikDev/qwik#5695 - docs(showcase): update metrics by [@​gioboa](https://togithub.com/gioboa) in [QwikDev/qwik#5707 - fix(types): untyped components, test more edge cases by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5713 - docs(showcase): add Zhou's portfolio by [@​linkfang](https://togithub.com/linkfang) in [QwikDev/qwik#5710 - chore: upgrades by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5705 - fix(qwik): register new index.d.ts package file by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5715 - docs: move props example after local state and useStore explanation by [@​Balastrong](https://togithub.com/Balastrong) in [QwikDev/qwik#5718 - docs: emphasize on useStore and onInput$ by [@​Balastrong](https://togithub.com/Balastrong) in [QwikDev/qwik#5719 - docs: add Storybook Examples by [@​thenhawke](https://togithub.com/thenhawke) in [QwikDev/qwik#5720 - fix(jsx-qwik-attributes): fix ts error TS4023 by [@​maiieul](https://togithub.com/maiieul) in [QwikDev/qwik#5722 - fix(types): JSX.Element is JSXOutput by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5723 - fix: prevent race condition by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5711 - fix: build from scratch + insights by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5724 - docs: Good first issue link doesn't lead you to properly label "COMMUNITY: good first issue" by [@​aendel](https://togithub.com/aendel) in [QwikDev/qwik#5726 - docs: fixed CodeSandbox/CodeFile src paths to match github files by [@​aendel](https://togithub.com/aendel) in [QwikDev/qwik#5725 - fix: Uppercase handling for SameSite cookie values by [@​ksjogo](https://togithub.com/ksjogo) in [QwikDev/qwik#5603 - feat(link): prefetch symbols by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5480 - docs: Fixed various typos (or misspelled words) in documentation files by [@​aendel](https://togithub.com/aendel) in [QwikDev/qwik#5728 - chore: extra type tests by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5580 - fix(build): qwik binary path in package.json by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5729 - fix(routing): fallback to hard navigation when soft navigation fails. by [@​iamriajul](https://togithub.com/iamriajul) in [QwikDev/qwik#5521 - fix(JSX): remove Promise from FC by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5730 - fix(core): serialize the 'key' attribute of JSX nodes by [@​yanivhamo](https://togithub.com/yanivhamo) in [QwikDev/qwik#5501 - fix(repl): give monaco the names of the imports by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5734 - docs(cookbook): add Combine Request Handlers example by [@​gioboa](https://togithub.com/gioboa) and [@​erikras](https://togithub.com/erikras) in [QwikDev/qwik#5733 - fix(docs): grammar in "Project Structure" page by [@​ChallengeHandler](https://togithub.com/ChallengeHandler) in [QwikDev/qwik#5735 - chore: 1.4.0 by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5736 ##### New Contributors - [@​blueagler](https://togithub.com/blueagler) made their first contribution in [QwikDev/qwik#5695 - [@​linkfang](https://togithub.com/linkfang) made their first contribution in [QwikDev/qwik#5710 - [@​Balastrong](https://togithub.com/Balastrong) made their first contribution in [QwikDev/qwik#5718 - [@​thenhawke](https://togithub.com/thenhawke) made their first contribution in [QwikDev/qwik#5720 - [@​aendel](https://togithub.com/aendel) made their first contribution in [QwikDev/qwik#5726 - [@​ksjogo](https://togithub.com/ksjogo) made their first contribution in [QwikDev/qwik#5603 - [@​yanivhamo](https://togithub.com/yanivhamo) made their first contribution in [QwikDev/qwik#5501 - [@​ChallengeHandler](https://togithub.com/ChallengeHandler) made their first contribution in [QwikDev/qwik#5735 **Full Changelog**: QwikDev/qwik@v1.3.5...v1.4.0 ### [`v1.3.5`](https://togithub.com/BuilderIO/qwik/releases/tag/v1.3.5) [Compare Source](https://togithub.com/BuilderIO/qwik/compare/v1.3.4...v1.3.5) #### What's Changed - docs: fix typos for theme management cookbook by [@​harshmangalam](https://togithub.com/harshmangalam) in [QwikDev/qwik#5698 - fix(labs): double slash when used with BASE_URL by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5700 - fix: improve escapeText and unescapeText replace to prevent XSS by [@​ignatvilesov](https://togithub.com/ignatvilesov) in [QwikDev/qwik#5701 - chore: allow any undici version by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5703 - docs(propfunctionprops): mark propfunctionprops as deprecated by [@​maiieul](https://togithub.com/maiieul) in [QwikDev/qwik#5680 - chore: 1.3.5 by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5704 **Full Changelog**: QwikDev/qwik@v1.3.4...v1.3.5 ### [`v1.3.4`](https://togithub.com/BuilderIO/qwik/releases/tag/v1.3.4) [Compare Source](https://togithub.com/BuilderIO/qwik/compare/v1.3.3...v1.3.4) ##### What's Changed - chore: update deps + monaco by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5685 - chore: Remove duplicated dist directory from .prettierignore by [@​nelsonprsousa](https://togithub.com/nelsonprsousa) in [QwikDev/qwik#5687 - docs: add og-img integration guide by [@​fabian-hiller](https://togithub.com/fabian-hiller) in [QwikDev/qwik#5686 - chore: improve FunctionComponent by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5688 - fix: improve escapeText replace by [@​ignatvilesov](https://togithub.com/ignatvilesov) in [QwikDev/qwik#5689 - fix(optimizer): use correct prop in omit by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5690 - chore: 1.3.4 by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5691 - docs: fix typos for nav link cookbook by [@​harshmangalam](https://togithub.com/harshmangalam) in [QwikDev/qwik#5694 ##### New Contributors - [@​ignatvilesov](https://togithub.com/ignatvilesov) made their first contribution in [QwikDev/qwik#5689 **Full Changelog**: QwikDev/qwik@v1.3.3...v1.3.4 ### [`v1.3.3`](https://togithub.com/BuilderIO/qwik/releases/tag/v1.3.3) [Compare Source](https://togithub.com/BuilderIO/qwik/compare/v1.3.2...v1.3.3) ##### What's Changed - fix(cli): Update jokes.json by [@​mayank99](https://togithub.com/mayank99) in [QwikDev/qwik#5657 - docs: for accessing the .env variables in serverfull architechture example in express by [@​sreeisalso](https://togithub.com/sreeisalso) in [QwikDev/qwik#5619 - docs: change placement of {...props} and add section by [@​Adbib](https://togithub.com/Adbib) in [QwikDev/qwik#5664 - docs: Update build command in Static Site Generation (SSG) Overview docs by [@​lelouchB](https://togithub.com/lelouchB) in [QwikDev/qwik#5668 - fix(starter): rename tailwind postcss.config file by [@​iamriajul](https://togithub.com/iamriajul) in [QwikDev/qwik#5669 - fix: fixing running qwik-development-server on windows machine by [@​hassanzohdy](https://togithub.com/hassanzohdy) in [QwikDev/qwik#5593 - fix(starter): add vite plugin type by [@​iamriajul](https://togithub.com/iamriajul) in [QwikDev/qwik#5670 - feat(qwik-react): directive aliases for Astro and other package conflicts by [@​thejackshelton](https://togithub.com/thejackshelton) in [QwikDev/qwik#5651 - feat: qwik-prefetch-worker by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5618 - refactor: Clarify var naming qwikloader.ts by [@​gabrielgrant](https://togithub.com/gabrielgrant) in [QwikDev/qwik#5546 - docs: fix entry file name by [@​AustinGil](https://togithub.com/AustinGil) in [QwikDev/qwik#5646 - feat(labs): Support base prefix in untypedAppUrl by [@​tera-ny](https://togithub.com/tera-ny) in [QwikDev/qwik#5615 - style(starter templates): updates to starter templates names by [@​abstractalgo](https://togithub.com/abstractalgo) in [QwikDev/qwik#5479 - fix: Clearer error message for `resolveValue` for `head` function by [@​colelawrence](https://togithub.com/colelawrence) in [QwikDev/qwik#5624 - refactor(starter): add alt attribute in order to improve accessibility by [@​tidiview](https://togithub.com/tidiview) in [QwikDev/qwik#5674 - refactor(insights): remove netlify.toml causing confusion by [@​mhevery](https://togithub.com/mhevery) in [QwikDev/qwik#5676 - feat(cookbook): add Algolia search by [@​gioboa](https://togithub.com/gioboa) in [QwikDev/qwik#5675 - fix(cookbook): change Algolia example by [@​gioboa](https://togithub.com/gioboa) in [QwikDev/qwik#5677 - fix: polymorphic component types by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5672 - chore: add Nix build flake environment by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5594 - fix(nix): missing .envrc by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5678 - fix(nix): make rust and wasm builds work by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5679 - fix: dynamic refs by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5681 - fix(core): Make polymorphic components easy by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5682 - chore: 1.3.3 by [@​wmertens](https://togithub.com/wmertens) in [QwikDev/qwik#5683 ##### New Contributors - [@​mayank99](https://togithub.com/mayank99) made their first contribution in [QwikDev/qwik#5657 - [@​lelouchB](https://togithub.com/lelouchB) made their first contribution in [QwikDev/qwik#5668 - [@​hassanzohdy](https://togithub.com/hassanzohdy) made their first contribution in [QwikDev/qwik#5593 - [@​AustinGil](https://togithub.com/AustinGil) made their first contribution in [QwikDev/qwik#5646 - [@​tera-ny](https://togithub.com/tera-ny) made their first contribution in [QwikDev/qwik#5615 **Full Changelog**: QwikDev/qwik@v1.3.2...v1.3.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 9pm on sunday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ascorbic/unpic-img). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE1My4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #5514
Overview
This just adds a try/catch for soft navigation, so when soft navigation fails (may be due to js file does not exist) it will fallback to hard navigation using browser's
window.location.href.What is it?
Description
This issue is related to: #5514
Checklist: