Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): fix drizzle integration page not showing up #5958

Conversation

LazyClicks
Copy link
Contributor

@LazyClicks LazyClicks commented Mar 5, 2024

Overview

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

missing folders from the integration (db and migration folder) that didnt get commited due to being empty in the earlier pr
as well as hopefully fixing the drizzle integration page not showing up in sidebar

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

Copy link

netlify bot commented Mar 5, 2024

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 46f7a28

@LazyClicks LazyClicks changed the title chore(docs):fix drizzle integration page not showing up chore(docs): fix drizzle integration page not showing up Mar 5, 2024
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LazyClicks it looks good to me. Thanks

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that .gitkeep is the correct files to keep the folder.

@LazyClicks
Copy link
Contributor Author

@gioboa its done

@gioboa gioboa merged commit 56ee86b into QwikDev:main Mar 6, 2024
22 checks passed
@LazyClicks
Copy link
Contributor Author

thanks @gioboa

@LazyClicks
Copy link
Contributor Author

@gioboa would this pr be visible rn or till next release?

@gioboa
Copy link
Member

gioboa commented Mar 6, 2024

@gioboa would this pr be visible rn or till next release?

I added the integration in the menu with this PR #5962
Now it's working fine.

@LazyClicks
Copy link
Contributor Author

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants