Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add missing import #6225

Merged
merged 2 commits into from
May 5, 2024
Merged

Conversation

krisantuswanandi
Copy link
Contributor

Overview

add missing import in https://qwik.dev/docs/deployments/static/

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

add missing import in https://qwik.dev/docs/deployments/static/

Use cases and why

N/A

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality (no test needed)

@krisantuswanandi
Copy link
Contributor Author

I think it's better to split this part into a new "Manual Installation" section, something like this. wdyt? I can help updating all the deployment docs.

Above command will create a directory at project root named `adapters/static/vite.config.ts` with the below code.
```tsx file="adapters/static/vite.config.ts"
import { staticAdapter } from "@builder.io/qwik-city/adapters/static/vite";
import { extendConfig } from '@builder.io/qwik-city/vite';
import baseConfig from '../../vite.config';

If it's not recommended to do manual installation, then it's better to remove the code from the docs, something like https://qwik.dev/docs/deployments/firebase/

@PatrickJS
Copy link
Member

@krisantuswanandi can you make another PR to split it up

@PatrickJS PatrickJS enabled auto-merge (squash) May 5, 2024 18:11
@PatrickJS PatrickJS merged commit 65f679e into QwikDev:main May 5, 2024
20 checks passed
@krisantuswanandi krisantuswanandi deleted the static-adapter branch May 6, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants