Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: SSG ignoring the index page when trailingSlash is false #6304

Merged
merged 2 commits into from
May 13, 2024
Merged

fix: SSG ignoring the index page when trailingSlash is false #6304

merged 2 commits into from
May 13, 2024

Conversation

JerryWu1234
Copy link
Contributor

@JerryWu1234 JerryWu1234 commented May 13, 2024 •
edited
Loading

Overview

fix:#6247

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@JerryWu1234 JerryWu1234 marked this pull request as ready for review May 13, 2024 10:54
gioboa
gioboa approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help.
Did you test this change locally?

@JerryWu1234
Copy link
Contributor Author

JerryWu1234 commented May 13, 2024 •
edited
Loading

Thanks for your help.

Did you test this change locally?

Of course, I will send a picture that includes my testing late

@gioboa gioboa changed the title fix: a bug fix: SSG ignoring the index page when trailingSlash is false May 13, 2024
@gioboa gioboa merged commit dde6644 into QwikDev:main May 13, 2024
30 checks passed
@gioboa gioboa mentioned this pull request May 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gioboa gioboa gioboa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JerryWu1234 @gioboa