fix(bun): Rewrite TextEncoderStream polyfill implementation for Bun middleware #6309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrickJS
changed the title
PatrickJS
approved these changes
May 13, 2024
|
The PR itself is ready, but it need to be tested anyway. I will do it manually, since I am not much familiar with the codebase. Please, let me know if I can add some automated tests. |
|
this should be fine as is. bun should include TextEncoderStream anyways |
|
Alright then. |
|
@octet-stream I'll fix the pr don't worry about it |
|
Thanks @octet-stream for your help 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #5929
The implementation of bun adapter implemented in #5129 has also introduced a polyfill for TextEncoderStream. While the adapter itself works, this polyfill introduced a bug, caused on attempt to close a response stream (see #5929 for more info). This PR fixes this issue by rewriting the polyfill based on this comment: #5929 (comment)
What is it?
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Use cases and why
Checklist: