fix(server$): return content type changes #6345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for qwik-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Deploying qwik-docs with
|
| Latest commit: |
81332cd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8a857b08.qwik-8nx.pages.dev |
| Branch Preview URL: | https://fix-server--json-response-la.qwik-8nx.pages.dev |
PatrickJS
commented
May 21, 2024
| @@ -380,6 +380,18 @@ export const serverQrl = <T extends ServerFunction>( | |||
| throw obj; | |||
| } | |||
| return obj; | |||
| } else if (contentType === 'application/json') { | |||
There was a problem hiding this comment.
theses cases should never be hit but in cases that I mentioned it's better that they're handled
thejackshelton
approved these changes
May 21, 2024
|
You are doing a great job @PatrickJS 🚀 |
wmertens
reviewed
May 21, 2024
| @@ -380,6 +380,18 @@ export const serverQrl = <T extends ServerFunction>( | |||
| throw obj; | |||
| } | |||
| return obj; | |||
| } else if (contentType === 'application/json') { | |||
| const obj = await res.json(); | |||
| if (res.status === 500) { | |||
There was a problem hiding this comment.
it should never hit this case but for example of the Lambda blows up then aws will change the return headers/value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when server$ lambda blows up the content type changes.
this is needed for debugging