Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): delete HTMLFragment #6350

Merged
merged 2 commits into from
May 22, 2024

Conversation

Varixo
Copy link
Member

@Varixo Varixo commented May 21, 2024

This PR removes the HTMLFragment component. It is not needed.

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏great

Copy link
Member

@thejackshelton thejackshelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah looks like CI is failing but I can't seem to see why.

Linting error in prettier, otherwise:

LGTM! 🙌

@Varixo
Copy link
Member Author

Varixo commented May 21, 2024

Ah looks like CI is failing but I can't seem to see why.

Linting error in prettier, otherwise:

LGTM! 🙌

Yeah, this is weird because I didn't change anything inside the vnode-diff file 🤔

@Varixo Varixo merged commit 49acac6 into QwikDev:build/v2 May 22, 2024
14 of 18 checks passed
@Varixo Varixo deleted the build/v2-delete-html-fragment branch May 22, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants