Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin-qwik): allow loaders in routes with JSX extension #6374

Merged
merged 1 commit into from
May 23, 2024

Conversation

loriswit
Copy link
Contributor

@loriswit loriswit commented May 23, 2024

fix #6361

Overview

See related issue: #6361

I suppose we could also update the related doc, but I'm not sure that's necessary.

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

ESLint is triggering an invalidLoaderLocation warning when loaders are located in a .jsx file instead of .tsx.

Expected behavior

Loaders should be considered valid in .jsx files as well.

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

Copy link

netlify bot commented May 23, 2024

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit b419ef1

@PatrickJS PatrickJS merged commit ce6de14 into QwikDev:main May 23, 2024
22 checks passed
@PatrickJS
Copy link
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐞] ESLint: invalidLoaderLocation should not be triggered if filename extension is JSX
2 participants