Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update use-resource.ts #6402

Merged
merged 2 commits into from
May 27, 2024
Merged

Conversation

greatgraphicdesign
Copy link
Contributor

Duplicates the text changes that were approved for the core readme in this PR: https://github.com/QwikDev/qwik/pull/6354/files

Overview

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Use cases and why

Catching an error in useResource$ will prevent <Resource /> from getting the onRejected state.

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

Duplicates the text changes that were approved for the core readme in this PR: https://github.com/QwikDev/qwik/pull/6354/files
@greatgraphicdesign greatgraphicdesign requested a review from a team as a code owner May 26, 2024 22:01
Copy link

netlify bot commented May 26, 2024

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit a246f89

gioboa
gioboa previously approved these changes May 27, 2024
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @greatgraphicdesign for your help

@gioboa gioboa enabled auto-merge (squash) May 27, 2024 04:00
@gioboa gioboa merged commit b41a2a8 into QwikDev:main May 27, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants