Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jsx-generated): simplify input type #6418

Merged
merged 4 commits into from
Jun 2, 2024

Conversation

maiieul
Copy link
Contributor

@maiieul maiieul commented May 28, 2024

Overview

Another attempt for #6398

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@maiieul maiieul requested a review from a team as a code owner May 28, 2024 17:43
Copy link

netlify bot commented May 28, 2024

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit f22eb15

@maiieul maiieul requested a review from wmertens May 30, 2024 07:09
wmertens
wmertens previously approved these changes May 30, 2024
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, too bad prettier is complaining again ☹️

LGTM

packages/qwik/src/core/render/jsx/types/jsx-generated.ts Outdated Show resolved Hide resolved
@maiieul
Copy link
Contributor Author

maiieul commented May 30, 2024

Nice, too bad prettier is complaining again ☹️

LGTM

Yeah I think the real fix here is to fix the prettier issue I'm running into. Don't you have it if you make a PR with the same changes as mines (but you run pnpm fmt first)?

@maiieul
Copy link
Contributor Author

maiieul commented May 30, 2024

Well, linter still not passing... It's not easy to guess what the linter is doing in CI 😅

@wmertens, could you try making the PR, just marking the type as optional as I did in my first PR, and pnpm fmt? See if that works on your end?

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @maiieul

@gioboa gioboa enabled auto-merge (squash) June 2, 2024 18:41
@gioboa gioboa merged commit 5244042 into QwikDev:main Jun 2, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants