Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improved clarity in tutorial #6463

Merged
merged 2 commits into from
Jun 8, 2024

Conversation

thejackshelton-kunaico
Copy link
Contributor

Overview

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

Copy link

netlify bot commented Jun 5, 2024

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 6fedeb9

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's nice to me

PatrickJS
PatrickJS previously approved these changes Jun 7, 2024
@PatrickJS PatrickJS enabled auto-merge (squash) June 7, 2024 20:06
gioboa
gioboa previously approved these changes Jun 7, 2024
@shairez shairez closed this Jun 7, 2024
auto-merge was automatically disabled June 7, 2024 22:40

Pull request was closed

@shairez shairez reopened this Jun 7, 2024
@shairez shairez enabled auto-merge (squash) June 7, 2024 22:40
Copy link

pkg-pr-new bot commented Jun 7, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@builder.io/qwik (6fedeb9)

npm i https://pkg.pr.new/@builder.io/qwik@6463

@builder.io/qwik-city (6fedeb9)

npm i https://pkg.pr.new/@builder.io/qwik-city@6463

eslint-plugin-qwik (6fedeb9)

npm i https://pkg.pr.new/eslint-plugin-qwik@6463

create-qwik (6fedeb9)

npm i https://pkg.pr.new/create-qwik@6463

@shairez shairez disabled auto-merge June 7, 2024 23:01
@shairez shairez closed this Jun 7, 2024
@shairez shairez reopened this Jun 7, 2024
@shairez shairez closed this Jun 7, 2024
@shairez shairez reopened this Jun 7, 2024
@shairez shairez closed this Jun 7, 2024
@shairez shairez reopened this Jun 7, 2024
@shairez shairez dismissed stale reviews from gioboa and PatrickJS via 6fedeb9 June 7, 2024 23:58
@shairez shairez requested a review from a team as a code owner June 7, 2024 23:58
@shairez shairez merged commit c89a8f6 into QwikDev:main Jun 8, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants