Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added reactivity best practice #6521

Merged
merged 1 commit into from
Jun 12, 2024
Merged

docs: added reactivity best practice #6521

merged 1 commit into from
Jun 12, 2024

Conversation

shairez
Copy link
Contributor

@shairez shairez commented Jun 12, 2024

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Added another best practices that avoids subscribing inside the component$ function.

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@shairez shairez requested review from a team as code owners June 12, 2024 00:27
Copy link

netlify bot commented Jun 12, 2024

Deploy Preview for qwik-insights ready!

Name Link
🔨 Latest commit 83de928
🔍 Latest deploy log https://app.netlify.com/sites/qwik-insights/deploys/6668eb87dc940b0008932cab
😎 Deploy Preview https://deploy-preview-6521--qwik-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Jun 12, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@builder.io/qwik (83de928)

npm i https://pkg.pr.new/@builder.io/qwik@6521

@builder.io/qwik-city (83de928)

npm i https://pkg.pr.new/@builder.io/qwik-city@6521

eslint-plugin-qwik (83de928)

npm i https://pkg.pr.new/eslint-plugin-qwik@6521

create-qwik (83de928)

npm i https://pkg.pr.new/create-qwik@6521

Copy link

Deploying qwik-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 83de928
Status: ✅  Deploy successful!
Preview URL: https://8b674b6b.qwik-8nx.pages.dev
Branch Preview URL: https://shairez-patch-1.qwik-8nx.pages.dev

View logs

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @shairez 👍

@shairez shairez merged commit 646165f into main Jun 12, 2024
29 checks passed
@shairez shairez deleted the shairez-patch-1 branch June 12, 2024 00:34
genki pushed a commit to genki/qwik that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants