Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve new SW logic #6641

Merged
merged 2 commits into from
Jul 8, 2024
Merged

fix: improve new SW logic #6641

merged 2 commits into from
Jul 8, 2024

Conversation

gioboa
Copy link
Member

@gioboa gioboa commented Jul 3, 2024

Overview

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@gioboa gioboa requested a review from a team as a code owner July 3, 2024 22:28
Copy link

netlify bot commented Jul 3, 2024

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 0236e28

Copy link

pkg-pr-new bot commented Jul 3, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: 0236e28

@builder.io/qwik

npm i https://pkg.pr.new/@builder.io/qwik@6641

@builder.io/qwik-city

npm i https://pkg.pr.new/@builder.io/qwik-city@6641

eslint-plugin-qwik

npm i https://pkg.pr.new/eslint-plugin-qwik@6641

create-qwik

npm i https://pkg.pr.new/create-qwik@6641


templates

@gioboa gioboa merged commit 9cfb612 into QwikDev:main Jul 8, 2024
20 checks passed
@gioboa gioboa deleted the fix/SW-different-dir branch July 8, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants