Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add docker compose - STILL WIP #858

Closed
wants to merge 4 commits into from
Closed

Conversation

shairez
Copy link
Contributor

@shairez shairez commented Jul 27, 2022

This is not done yet, I'm running into an error

See my other comment below

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

this will enable an easier way for contributors to test stuff locally without installing all of the
depenedencies like rust etc.

see #794

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

this will enable an easier way for contributors to test stuff locally without installing all of the
depenedencies like rust etc.

re QwikDev#794
@shairez
Copy link
Contributor Author

shairez commented Jul 27, 2022

Hey, I'm getting the following error inside of the docker container -

ReferenceError: fetch is not defined
    at Module.init (file:///opt/qwik/node_modules/@builder.io/qwik/bindings/qwik.wasm.mjs:421:9)
    at loadPlatformBinding (file:///opt/qwik/node_modules/@builder.io/qwik/optimizer.mjs:537:25)
    at async createOptimizer (file:///opt/qwik/node_modules/@builder.io/qwik/optimizer.mjs:567:85)
    at async Object.init (file:///opt/qwik/node_modules/@builder.io/qwik/optimizer.mjs:832:47)
    at async Object.config (file:///opt/qwik/node_modules/@builder.io/qwik/optimizer.mjs:1414:7)
    at async resolveConfig (file:///opt/qwik/node_modules/vite/dist/node/chunks/dep-1513d487.js:62385:25)
    at async doBuild (file:///opt/qwik/node_modules/vite/dist/node/chunks/dep-1513d487.js:43308:20)
    at async build (file:///opt/qwik/node_modules/vite/dist/node/chunks/dep-1513d487.js:43297:16)
    at async CAC.<anonymous> (file:///opt/qwik/node_modules/vite/dist/node/cli.js:747:9)

@manucorporat it doesn't seem like a windows issue, for some reason, fetch cannot be found where evet the wsamgets run 🤷‍♂️

@nnelgxorz nnelgxorz mentioned this pull request Jul 27, 2022
7 tasks
@shairez
Copy link
Contributor Author

shairez commented Jul 27, 2022

OK Build issues are solved

Still need to fix the running of the e2e tests (I think it's because the docker image is not ubuntu) I'll continue tomorow

@zanettin zanettin added the COMP: DX Developer Experience related issue label Feb 25, 2023
@zanettin
Copy link
Contributor

@shairez can we close this PR in favor of #5237 ?

@shairez
Copy link
Contributor Author

shairez commented Oct 5, 2023

Yes, thanks for the ping @zanettin !

@shairez shairez closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COMP: DX Developer Experience related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants