Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix merge #16

Merged
merged 1 commit into from May 4, 2019

Conversation

Projects
None yet
2 participants
@itzandroidtab
Copy link
Contributor

commented May 3, 2019

Fixed a bug that happened when i merged some changes

@itzandroidtab itzandroidtab requested a review from PatrickDekker98 May 3, 2019

@itzandroidtab itzandroidtab added the bug label May 3, 2019

@itzandroidtab itzandroidtab requested review from LRstudentHU and gerritvanos May 3, 2019

@@ -6,8 +6,7 @@

namespace r2d2::usart {
enum class usart_ports_c {
uart0,
uart1,
uart1 = 0,

This comment has been minimized.

Copy link
@gerritvanos

gerritvanos May 4, 2019

Contributor

i don't now the technical details but seems strage to me to only =0 1 of them??

This comment has been minimized.

Copy link
@itzandroidtab

itzandroidtab May 4, 2019

Author Contributor

I just want to make sure it starts with 0. It is probably not needed.

@gerritvanos
Copy link
Contributor

left a comment

okay

@itzandroidtab itzandroidtab merged commit 83758d1 into release May 4, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.