Display server region in serverbrowser #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeckoEidechse
added
feedback wanted
|
Set to draft as the PR it depends on is not yet merged. |
5 tasks
|
What's blocking this? |
It needs R2Northstar/NorthstarMasterServer#84 and R2Northstar/NorthstarLauncher#232 to be merged first. |
|
Alignment is scuffed but still works otherwise :D
|
|
isn't that how the alignment is supposed to be? centered? |
Yes but becuase most names max out the column it looks a bit weird IMO. Doesn't matter though cause R2Northstar/Atlas#13 should shorten things a bit ^^ |
|
Still in draft cause I'm missing translations, pinging translators for it ^^ |
|
Translations still default to english so it shouldn't matter |
|
Translations are done now and PR is ready for review :> |
GeckoEidechse
added
needs testing
ASpoonPlaysGames
requested changes
Nov 26, 2022
F1F7Y
approved these changes
Dec 2, 2022
pg9182
approved these changes
Dec 2, 2022
|
@pg9182 can you say what you reviewed |
GeckoEidechse
removed
the
needs code review
uniboi
approved these changes
Dec 3, 2022
ASpoonPlaysGames
removed
the
needs testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the existing and currently still unused latency column in the serverbrowser with a new column called "Region". Note that I have replaced most of the references to "*latency*" with "*region*".
Still missing are:
Depends on
R2Northstar/NorthstarMasterServer#84 andR2Northstar/NorthstarLauncher#232 (merged)