Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Add (optional?) entry for commit hash to mods.json #6

Closed
GeckoEidechse opened this issue Nov 14, 2023 · 3 comments
Closed

RFC: Add (optional?) entry for commit hash to mods.json #6

GeckoEidechse opened this issue Nov 14, 2023 · 3 comments

Comments

@GeckoEidechse
Copy link
Member

Related to #5

Having the commit hash next to version and checksum would be useful to detect someone shifting around the tag that was used validate a previous version which could allow hiding commits if we only look at differential changes.

This would change

{
    "Fifty.mp_frostbite": {
        "DependencyPrefix": "Fifty-Frostbite",
        "Versions" : [
            { 
                "Version": "0.0.1",
                "Checksum": "8cf111c9ac2ab1521677769702e10be4db8d47c0eca16bda197aceb895cf2b5c"
            }
        ]
    }
}

to

{
    "Fifty.mp_frostbite": {
        "DependencyPrefix": "Fifty-Frostbite",
        "Versions" : [
            { 
                "Version": "0.0.1",
                "CommitHash": "446f6e2774206c6f6f6b20626568696e6420746865206375727461696e212121",
                "Checksum": "8cf111c9ac2ab1521677769702e10be4db8d47c0eca16bda197aceb895cf2b5c"
            }
        ]
    }
}

I'm not sure if we should make the key optional or not as maps might have an issue in general with being hosted on GitHub due to their file sizes.

@Alystrasz
Copy link
Contributor

Map size can not be an issue at all; @uniboi showed it's possible to split the map in small chunks (uploadable to GitHub), that are regrouped together when uploading to Thunderstore.

Example repo: https://github.com/uniboi/s2space
Associated mod: https://northstar.thunderstore.io/package/odds/s2space/

@Alystrasz
Copy link
Contributor

Otherwise, including commit hashes seems a good idea to me.

@GeckoEidechse
Copy link
Member Author

Closed by #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants