Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting to implement some basic tests to allow removal of LiteralProxies class in near future #16

Merged
merged 5 commits into from
Oct 27, 2018

Conversation

wrobell
Copy link
Contributor

@wrobell wrobell commented Oct 15, 2018

This is related to the issue #13.

@wrobell
Copy link
Contributor Author

wrobell commented Oct 18, 2018

I have also test for dt-type2 rule. I can see there is processing for the rule in RDFClosure.OWLRL module, however it seems in one of the post-processing steps the result of inference is ignored or removed. Is that a bug?

@ashleysommer
Copy link
Collaborator

it seems in one of the post-processing steps the result of inference is ignored or removed. Is that a bug?

Good question. It is probably a bug. Do you have any more information? Have you tried to re-enable the post-processing steps to see what it does?

@wrobell
Copy link
Contributor Author

wrobell commented Oct 23, 2018

I believe, on this branch, I have not disabled any post-processing steps.

@wrobell
Copy link
Contributor Author

wrobell commented Oct 25, 2018

I have added unit test for dt-type2 OWL 2 RL rule in this pull request. Also raised ticket #19 about dt-type2 inference issue.

@nicholascar
Copy link
Member

Thanks for the tests. I'll pull this through now but really we all need a plan for a comprehensive set of tests against the spec in order to identify all bugs. There are random rules commented out in the code with no explanation so I don't know what the effects of the dissablement of them is. Comprehensive testing against the RL rules will tell.

@nicholascar nicholascar merged commit feb2ed8 into RDFLib:master Oct 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants