Some cleanup from self review

docker-compose.tests.yml

@@ -24,4 +24,4 @@ services:
     volumes:
       - .:/rdflib
     working_dir: /rdflib
-    command: ["python", "-m", "mypy", "--show-error-context", "--show-error-codes" ,"/rdflib/rdflib"]
+    command: ["python", "-m", "mypy", "--show-error-context", "--show-error-codes" ,"rdflib"]

docs/developers.rst

@@ -37,7 +37,7 @@ Run tests with `pytest <https://docs.pytest.org/en/latest/>`_:
    $ pytest
 
 
-Specific tests can be run by file name. For example::
+Specific tests can be run by file name. For example:
 
 .. code-block:: bash
 

test/earl.py

@@ -62,6 +62,10 @@ class EARL(DefinedNamespace):
 
 
 class EarlReport:
+    """
+    This is a helper class for building an EARL report graph.
+    """
+
     def __init__(
         self,
         asserter_uri: Optional[str] = None,
@@ -190,7 +194,7 @@ def pytest_unconfigure(config):
         config.pluginmanager.unregister(earl)
 
 
-# https://docs.pytest.org/en/6.2.x/reference.html#pytest.hookspec.pytest_runtest_protocol
+# https://docs.pytest.org/en/latest/reference.html#pytest.hookspec.pytest_runtest_protocol
 
 
 class TestResult(enum.Enum):
@@ -214,11 +218,16 @@ def get_rdf_test_uri(cls, report: "TestReport") -> Optional[URIRef]:
 
 
 class EarlReporter:
+    """
+    This class is a pytest plugin that will write a EARL report with results for
+    every pytest which has a rdf_test_uri parameter that is a string or an
+    URIRef.
+    """
+
     def __init__(self, output_path: Path, report: Optional[EarlReport] = None) -> None:
         self.report = report if report is not None else EarlReport()
         self.output_path = output_path
 
-    # @pytest.mark.hookwrapper
     @pytest.hookimpl(hookwrapper=True)
     def pytest_runtest_makereport(
         self, item: Item, call: "CallInfo[None]"

test/manifest.py

@@ -188,12 +188,3 @@ def _str(x):
                     res,
                     syntax,
                 )
-
-
-def pytest_manifest(subtests: SubTests, testers, manifest, base=None, legacy=False):
-    for _type, rdf_test_uri, rdf_test in read_manifest(manifest, base, legacy):
-        if _type in testers:
-            with subtests.test(
-                _type=_type, rdf_test_uri=rdf_test_uri, rdf_test=rdf_test
-            ):
-                testers[_type](rdf_test)

test/testutils.py

@@ -460,6 +460,11 @@ def test_example(self) -> None:
 
 
 def eq_(lhs, rhs, msg=None):
+    """
+    This function mimicks the similar function from nosetest. Ideally nothing
+    should use it but there is a lot of code that still does and it's fairly
+    simple to just keep this small pollyfill here for now.
+    """
     if msg:
         assert lhs == rhs, msg
     else: