Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSVResultParser.parse eats exceptions #1477

Closed
aucampia opened this issue Nov 24, 2021 · 0 comments · Fixed by #1809
Closed

TSVResultParser.parse eats exceptions #1477

aucampia opened this issue Nov 24, 2021 · 0 comments · Fixed by #1809
Assignees
@aucampia
Labels
bug Something isn't working

Comments

@aucampia
Copy link
Member

This is eating exceptions which should not be eaten and should propagate:

rdflib/rdflib/plugins/sparql/results/tsvresults.py

Lines 91 to 94 in a24d534

except ParseException as err:
print(err.line)
print(" " * (err.column - 1) + "^")
print(err)

@aucampia aucampia added the bug Something isn't working label Jan 23, 2022
@aucampia aucampia self-assigned this Apr 10, 2022
aucampia added a commit to aucampia/rdflib that referenced this issue Apr 11, 2022
@aucampia
Convert test_sparql/test_tsvresults.py to pytest
bc4d229 
Converting to pytest in preperation for additional tests I will add for:
- RDFLib#1477
aucampia added a commit to aucampia/rdflib that referenced this issue Apr 11, 2022
@aucampia
Convert test_sparql/test_tsvresults.py to pytest
33aaae7 
Converting to pytest in preperation for additional tests I will add for:
- RDFLib#1477
@aucampia aucampia mentioned this issue Apr 11, 2022
Merged
3 tasks
aucampia added a commit to aucampia/rdflib that referenced this issue Apr 14, 2022
@aucampia
fix: propagate exceptions from SPARQL TSV result parser
34aa7f4 
This patch changes the `TSVResultParser` to not eat exceptions, as this
results in silent failures that are hard to debug, and in general all
functions should either do what they say they will or create an error
indication to the caller, which in python is done with exceptions.

Fixes:
- RDFLib#1477
@aucampia aucampia mentioned this issue Apr 14, 2022
Merged
4 tasks
@aucampia aucampia linked a pull request Apr 14, 2022 that will close this issue
fix: propagate exceptions from SPARQL TSV result parser #1809
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aucampia aucampia

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: propagate exceptions from SPARQL TSV result parser aucampia/rdflib
1 participant
@aucampia