fix: propagate exceptions from SPARQL TSV result parser #1809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aucampia
force-pushed
the
iwana-20220414T0947-test_result_parser
branch
from
b127e07
to
0dbb387
Compare
aucampia
requested review from
nicholascar,
ashleysommer,
a user and
white-gecko
aucampia
force-pushed
the
iwana-20220414T0947-test_result_parser
branch
from
0dbb387
to
d573727
Compare
This patch changes the `TSVResultParser` to not eat exceptions, as this results in silent failures that are hard to debug, and in general all functions should either do what they say they will or create an error indication to the caller, which in python is done with exceptions. Fixes: - RDFLib#1477
aucampia
force-pushed
the
iwana-20220414T0947-test_result_parser
branch
from
d573727
to
34aa7f4
Compare
ghost
approved these changes
Apr 14, 2022
nicholascar
approved these changes
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This patch changes the
TSVResultParserto not eat exceptions, as thisresults in silent failures that are hard to debug, and in general all
functions should either do what they say they will or create an error
indication to the caller, which in python is done with exceptions.
Fixes:
Checklist
the same change.
so maintainers can fix minor issues and keep your PR up to date.