Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup unnecessary handling of py3 literal comparsion ops #863

Closed
joernhees opened this issue Oct 27, 2018 · 1 comment · Fixed by #2745
Closed

cleanup unnecessary handling of py3 literal comparsion ops #863

joernhees opened this issue Oct 27, 2018 · 1 comment · Fixed by #2745
Labels
cleanup enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@joernhees
Copy link
Member

this is a reminder after #793
@joernhees joernhees added enhancement New feature or request cleanup help wanted Extra attention is needed good first issue Good for newcomers labels Oct 27, 2018
@nesaro
Copy link

nesaro commented Jun 2, 2020

Hi, I would like to help with this as I have experience with py2/py3 transition. Can you explain a bit further what's needed?

My understanding of the previous MR: It implemented an approximation of __gt__ for datetimes, time, and XML Documents

ghost pushed a commit to wallberg/rdflib that referenced this issue Mar 18, 2024
@wallberg
Cleanup literal comparison ops (RDFLib#863)
5c9d8f9 
Remove unnecessary handling of py3 literal comparison
ops since Literal provides total ordering.
@ghost ghost mentioned this issue Mar 18, 2024
Merged
3 tasks
nicholascar pushed a commit that referenced this issue Mar 20, 2024
@wallberg
Cleanup literal comparison ops (#863) (#2745)
84ed09a 
Remove unnecessary handling of py3 literal comparison
ops since Literal provides total ordering.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup literal comparison ops (#863) wallberg/rdflib
2 participants
@nesaro @joernhees