Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup literal comparison ops (#863) #2745

Merged

Conversation

ghost
Copy link

@ghost ghost commented Mar 18, 2024

Remove unnecessary handling of py3 literal comparison ops since Literal provides total ordering.

fixes #863

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

Remove unnecessary handling of py3 literal comparison
ops since Literal provides total ordering.
@coveralls
Copy link

Coverage Status

coverage: 90.963% (+0.004%) from 90.959%
when pulling 5c9d8f9 on wallberg-umd:issue-863-cleanup-literal-comparison
into 9834665 on RDFLib:main.

@nicholascar nicholascar self-requested a review March 20, 2024 02:27
Copy link
Member

@nicholascar nicholascar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much: cleanups in code are always very welcome!

@nicholascar nicholascar merged commit 84ed09a into RDFLib:main Mar 20, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cleanup unnecessary handling of py3 literal comparsion ops
3 participants