New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Algebra.py add DESCRIBE #1096
Conversation
Describe query fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#831 has been closed. What's this change meant to correct?
Sorry about that, 831 was accidentally mentioned for the corresponding pull request. It was 813 that was supposed to get addressed. |
Hi @luckyagarwal, thank you so much for addressing the issue of I see that this is passing all tests but can you please supply a test demonstrating that this PR handles |
I bumped into this same issue and checked out this branch to solve it, but then I found that ultimately, |
@bgyori are you keen to get |
As I understand it, it should not just be all statements matching the resource-to-describe in subject and object possition, but the CBD of the resource with is implemented in #968 . |
Yes, that’s why I implemented |
Futher, I think it should not be implemented in rdflib/rdflib/plugins/sparql/evaluate.py Lines 290 to 291 in e56df6e
|
@luckyagarwal are you interested in updating this PR in like with comments from @white-gecko? |
Hey, I am sorry to say but not now because I am swamped with other works. |
@luckyagarwal are you keen to readdress this PR? |
@nicholascar I was looking at resuming this effort - is work underway for DESCRIBE support in 6.x? I was also wondering why your |
This adds an implementation for SPARQL DESCRIBE queries, using the built-in `cbd` method. I see there are several issues and PRs for DESCRIBE implementation. I believe this should close #479 and should resolve #1913, or at least pick up where it left off. It should also resolve #1096. This implementation should support the full SPARQL specification for DESCRIBE; either explicit IRIs can be provided (with no WHERE clause), or variables projected from a WHERE clause can be provided, or variables projected from a WHERE clause AND explicit IRIs can be provided. If a WHERE clause is provided, it should be evaluated the same way as it would for a SELECT DISTINCT query (including dataset specifications). The expected results for the test cases provided match the behaviour seen when running the same queries against the same data using ARQ. A possible future extension would be to add a global option (similar to `rdflib.plugins.sparql.SPARQL_LOAD_GRAPHS`) to change the method used to describe resources instead of always using CBD.
fixes #813