Add SPARQL DESCRIBE query implementation #2221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgberg
force-pushed
the
sparql-describe-implementation
branch
from
93bae2a
to
6566af3
Compare
mgberg
force-pushed
the
sparql-describe-implementation
branch
from
6566af3
to
63755b8
Compare
|
Just for reference, two previous abandoned attempts at doing this: |
aucampia
reviewed
Feb 6, 2023
aucampia
approved these changes
Feb 6, 2023
There was a problem hiding this comment.
@mgberg thanks for the PR, it looks great as always, I just have a question regarding the change in rdflib/plugins/sparql/parser.py which I'm not entirely clear on.
The change should also be pretty safe as nothing should impact non-describe queries.
|
pre-commit.ci run |
aucampia
added a commit
to aucampia/rdflib
that referenced
this pull request
Mar 24, 2023
SPARQL DESCRIBE was implemented in <RDFLib#2221> so there should be no xfail on it tests for it. This change removes one such xfail that was in place.
4 tasks
aucampia
added a commit
that referenced
this pull request
Mar 25, 2023
SPARQL DESCRIBE was implemented in <#2221> so there should be no `xfail` on it tests for it. This change removes one such `xfail` that was in place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This adds an implementation for SPARQL DESCRIBE queries, using the built-in
cbdmethod. I see there are several issues and PRs for DESCRIBE implementation. I believe this should close #479 and should resolve #1913, or at least pick up where it left off. It should also resolve #1096.This implementation should support the full SPARQL specification for DESCRIBE; either explicit IRIs can be provided (with no WHERE clause), or variables projected from a WHERE clause can be provided, or variables projected from a WHERE clause AND explicit IRIs can be provided. If a WHERE clause is provided, it should be evaluated the same way as it would for a SELECT DISTINCT query (including dataset specifications).
The expected results for the test cases provided match the behavior seen when running the same queries against the same data using ARQ.
A possible future extension would be to add a global option (similar to
rdflib.plugins.sparql.SPARQL_LOAD_GRAPHS) to change the method used to describe resources instead of always using CBD.Checklist
the same change.
./examplesfor new features.CHANGELOG.md).so maintainers can fix minor issues and keep your PR up to date.