Updated tox config to run mypy in default environment #1450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Happy for this to go through but I think we need to coordinate on our tests to remove nose, implement pytest and thus make it easier for us to fully embrace Py 3.10. This adds 3.10 build but do they actually work? As per the issue seen in #1439? |
|
Marking as draft until #1439 |
aucampia
force-pushed
the
iwana-20211017T1353-update_tox
branch
2 times, most recently
from
3b39bce
to
88f6484
Compare
This is mainly so that the default tox environment mirrors the CI checks. Also: * Added some notes about tox in `developers.rst`. * Made the `mypy` tox environment run for all python versions.
aucampia
force-pushed
the
iwana-20211017T1353-update_tox
branch
from
88f6484
to
8f153f5
Compare
nicholascar
approved these changes
Dec 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly so that the default tox environment mirrors the CI
checks.
Also:
developers.rst.mypytox environment run for all python versions.