Remove deprecated Statement class #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this removal has triggered no test fails, I'm going to merge it without further reviews. |
nicholascar
approved these changes
Dec 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1158
Per the issue, it was mentioned that this was supposed to be removed in v5.1.0 or v6.0.0, but it is still present in the codebase.
I'm not sure whether we need to wait for a major version to release this as it is technically a breaking change — but as the issue mentioned, it's been deprecated for about 10 years at this point, so perhaps it's fine to remove it in a minor version. I have no strong opinions on this, just thought I'd bubble this up as I think it's well overdue for removal.