Remove redundant type ignores and fix typing errors #1759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aucampia
force-pushed
the
iwana-20220314T2212-fix_type_ignore
branch
2 times, most recently
from
a61c0fd
to
de1c74b
Compare
aucampia
changed the title
aucampia
force-pushed
the
iwana-20220314T2212-fix_type_ignore
branch
from
de1c74b
to
5fcf5b8
Compare
|
Just want to add a test for |
This seems to be related to changes in typeshed and mypy.
This is to test comparison of Docuemnt Type XML Nodes.
aucampia
force-pushed
the
iwana-20220314T2212-fix_type_ignore
branch
from
8da8821
to
8829edc
Compare
Comparison done in `_isEqualXMLNode` for `node.nodeType == XMLNode.DOCUMENT_TYPE_NODE`, was comparing `node.systemId == other.system.Id` instead of `node.systemId == other.systemId`.
|
Okay tests added now, issue reproduced here: https://github.com/RDFLib/rdflib/runs/5546115541 |
aucampia
added a commit
that referenced
this pull request
Mar 15, 2022
…ints Add documentation about type hints CI errors are unrelated to changes and are fixed in #1759
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be related to changes in typeshed and mypy.
Also fixed comparison done by
_isEqualXMLNodefornode.nodeType == XMLNode.DOCUMENT_TYPE_NODE,it was comparing
node.systemId == other.system.Idinstead of
node.systemId == other.systemId.