Move test_issue*.py into test_issues folder #1765
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
nicholascar
approved these changes
Mar 17, 2022
There was a problem hiding this comment.
Looks good to me: I'm happy to shorten the list of test files a developer is confronted with!
I've slowely tried to add test_parser_* for parser testing and test_serializer* for serializers, but, I suppose, better would be to have a parsers/ and serializers/ folder too, so we can drop the _parser & _serializer bit in the file names. @gjhiggins if you can, you could make that change here! If not, I'll do it after this PR is merged.
ghost
mentioned this pull request
Merged
|
Implemented in #1766 |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes